Skip to content

fix(client): GVR core resources caching #10014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix(client): GVR core resources caching #10014

merged 2 commits into from
Mar 5, 2025

Conversation

floreks
Copy link
Member

@floreks floreks commented Mar 5, 2025

GVR caching logic did not consider that there can be CRDs with the same names as the core resources in different groups. Since discovery client returns unsorted list with a randomly ordered elements, it resulted in raw client request to a different resource than expected.

Fixes #9994

@floreks floreks self-assigned this Mar 5, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2025
@floreks floreks added the kind/bug Categorizes issue or PR as related to a bug. label Mar 5, 2025
@floreks floreks changed the title fix: GVR core resources caching fix(client): GVR core resources caching Mar 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.94%. Comparing base (4111b4f) to head (60af182).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10014      +/-   ##
==========================================
- Coverage   35.95%   35.94%   -0.01%     
==========================================
  Files         306      306              
  Lines       14711    14711              
  Branches      202      202              
==========================================
- Hits         5289     5288       -1     
+ Misses       9198     9146      -52     
- Partials      224      277      +53     

@floreks floreks added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit a1e3c29 into master Mar 5, 2025
17 of 18 checks passed
@floreks floreks deleted the fix/issue-9984 branch March 5, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot edit deployment or Secrets when Crossplane is installed in cluster
4 participants