Skip to content

KEP-3488: Add information on expression composition #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2023
Merged

KEP-3488: Add information on expression composition #3669

merged 1 commit into from
Feb 8, 2023

Conversation

DangerOnTheRanger
Copy link
Contributor

  • One-line PR description:

This PR fills out the expression composition/lazy eval section on KEP-3488 (CEL for Admission Control).

  • Issue link:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2022
@DangerOnTheRanger
Copy link
Contributor Author

/test all

@DangerOnTheRanger DangerOnTheRanger marked this pull request as ready for review December 1, 2022 20:51
@k8s-ci-robot k8s-ci-robot requested a review from apelisse December 1, 2022 20:51
cici37
cici37 reviewed Dec 8, 2022
View reviewed changes
jpbetz
jpbetz reviewed Jan 12, 2023
View reviewed changes
@DangerOnTheRanger DangerOnTheRanger changed the title [WIP] KEP-3488: Add information on expression composition KEP-3488: Add information on expression composition Jan 17, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2023
@DangerOnTheRanger DangerOnTheRanger mentioned this pull request Jan 24, 2023
Merged
jpbetz
jpbetz reviewed Feb 2, 2023
View reviewed changes
This was referenced Feb 3, 2023
Merged
Closed
jpbetz
jpbetz reviewed Feb 3, 2023
View reviewed changes
jpbetz
jpbetz reviewed Feb 3, 2023
View reviewed changes
jpbetz
jpbetz reviewed Feb 3, 2023
View reviewed changes
jpbetz
jpbetz reviewed Feb 3, 2023
View reviewed changes
jpbetz
jpbetz reviewed Feb 3, 2023
View reviewed changes
jiahuif
jiahuif reviewed Feb 4, 2023
View reviewed changes
jiahuif
jiahuif reviewed Feb 7, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 8, 2023
lavalamp
lavalamp reviewed Feb 8, 2023
View reviewed changes
cici37
cici37 reviewed Feb 8, 2023
View reviewed changes
@DangerOnTheRanger DangerOnTheRanger force-pushed the expression-composition-update branch from 5676da1 to 49edd50 Compare February 8, 2023 19:31
@cici37
Copy link
Contributor

cici37 commented Feb 8, 2023

/assign @lavalamp
It should be ready for merging. Thank you!

@cici37
Copy link
Contributor

cici37 commented Feb 8, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2023
@lavalamp
Copy link
Member

lavalamp commented Feb 8, 2023

/lgtm
/approve

thanks.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DangerOnTheRanger, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 371a65c into kubernetes:master Feb 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@lavalamp lavalamp lavalamp left review comments

@jiahuif jiahuif jiahuif left review comments

@cici37 cici37 cici37 left review comments

@deads2k deads2k Awaiting requested review from deads2k

@fedebongio fedebongio Awaiting requested review from fedebongio

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@lavalamp lavalamp

@cici37 cici37

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
6 participants
@DangerOnTheRanger @k8s-ci-robot @cici37 @lavalamp @jpbetz @jiahuif