-
Notifications
You must be signed in to change notification settings - Fork 1.5k
WIP: KEP-5343: Updates to kube-proxy-backends #5344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Another possibility would be to deprecate the existing multi-mode | ||
kube-proxy binary in favor of having separate `kube-proxy-iptables`, | ||
`kube-proxy-ipvs`, and `kube-proxy-nftables` binaries (and perhaps, | ||
eventually, separate images). That would also work well with the plan | ||
to deprecate `ipvs` mode (and would allow us to completely remove | ||
the existing deprecated CLI options)... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is painful for developers and users, more binaries means more images to maintain and to release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiple binaries in the same image (built from nearly the same sources) would not really be much more work for anyone.
we could maybe even do the argv[0]
hack and just have a single binary, but have it behave differently depending on whether you invoke it as kube-proxy
or kube-proxy-nftables
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I was assuming independent artifacts
|
||
- Moving `kube-proxy-ipvs` to a staged repository. | ||
|
||
- Moving `kube-proxy-ipvs` to a non-staged repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will just fork the entire code in its own repo and open it for new maintainers, basically advocating for this option and what you conclude in the next paragraph
a good exercise for people willing to help will be to create a standalone repo with the ipvs proxy and windows proxy from the existing code in k/k to show feasibility ... I think that if that works we just start the deprecation period and point the people that wants to use them to this new repo ... |
(This is WIP, but ready for review; the WIP-iness is about figuring out the scope/details of what we want to do.)