-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Add ability to specify automountServiceAccountToken #6957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify automountServiceAccountToken #6957
Conversation
Welcome @joshuastern! |
Hi @joshuastern. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6572e9c
to
343790a
Compare
/assign @ChiefAlexander |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChiefAlexander, joshuastern The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add ability to specify the
automountServiceAccountToken
field on the nginx controller and defaultBackend service accounts.What this PR does / why we need it:
When this field is not explicitly set on service accounts, service account tokens will still get mounted. It is best practice to make this behavior visible to users.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: