-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Lower webhook timeout for digital ocean #7319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -163,6 +163,8 @@ controller: | |
service.beta.kubernetes.io/do-loadbalancer-enable-proxy-protocol: "true" | ||
config: | ||
use-proxy-protocol: "true" | ||
admissionWebhooks: | ||
timeoutSeconds: 29 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does 29 have any special meaning? Will there be any abnormalities if I use 25 or 30? @boukeversteegh There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, the tool used by DigitalOcean emits the error when the timeoutSeconds is 30 or higher, so it should be below 30. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That being said, I suppose 29s is a very high timeout for a web-request, but I don't understand the consequences of changing this value. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No other adverse effects were found, but it was indeed useful. Leave my LGTM There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Awesome! Thank you! |
||
|
||
EOF | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add this to Helm chart's values file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I had a suspicion that these files were generated but I'm not familiar with helm. It will take too much time for me to do it, but I don't mind to contribute / donate if someone is willing to pick this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found it!
7ffc2a2
I would be grateful for any help moving this through testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 if you need any help please feel free to ping me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, i'm giving it a go after all.
I managed to install go, helm, kind and make on Ubuntu WSL2, but while running
make dev-env
, it cannot connect tolocalhost:8080
due to a limitation in WSL2 where the ubuntu instance cannot access the host machine under the name 'localhost'.Is there anywhere where I can replace the hostname which is used during
make dev-env
? even if its temporarily/locally?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I overwrote localhost with my windows IP in
/etc/hosts
, but I still get the same error:I confirmed that neither in Windows nor in Ubuntu any service is running on 8080 (
telnet 127.0.0.1 8080
on both envs).Any idea what might go wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you set any proxy before you run
make dev-env
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no proxies configured in my WSL, no.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, now it seems to work...
i deleted
ingress-nginx-dev-control-plane
and re-ranmake dev-env
:-SThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, make test failed, but make e2e passed.
Not sure what to do with the normal make tests.
Maybe its good enough for further testing by you guys?
make test Failed
e2e test logs