Skip to content

feat: Add HorizontalPodAutoscaler created and deletionTimestamp info into metrics #2675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IgorIgnatevBolt
Copy link

@IgorIgnatevBolt IgorIgnatevBolt commented May 28, 2025

What this PR does / why we need it:

For some reason, there is no kube_horizontalpodautoscaler_created metric for HPA with creation timestamp information, PR is about to add it as a similarity to other objects.

Also, add kube_horizontalpodautoscaler_deletion_timestamp metrics to catch the deletion timestamp field.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

None

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2025
Copy link

linux-foundation-easycla bot commented May 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: IgorIgnatevBolt / name: Igor Ignatev (8fd0417)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: IgorIgnatevBolt
Once this PR has been reviewed and has the lgtm label, please assign catherinef-dev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 28, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @IgorIgnatevBolt!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 28, 2025
@IgorIgnatevBolt IgorIgnatevBolt marked this pull request as ready for review May 28, 2025 10:13
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mrueg May 28, 2025 10:13
@richabanker
Copy link
Contributor

/triage accepted
@rexagod can you PTAL? Thanks

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2025
@IgorIgnatevBolt IgorIgnatevBolt changed the title feat: Add HorizontalPodAutoscaler created info into metrics feat: Add HorizontalPodAutoscaler created and deletionTimestamp info into metrics Jun 2, 2025
@IgorIgnatevBolt
Copy link
Author

Just a small update, also added kube_horizontalpodautoscaler_deletion_timestamp metrics because I need this and fixed the formatting for the table docs

@IgorIgnatevBolt IgorIgnatevBolt force-pushed the feat-hpa-created-metric branch from 0e9b898 to 8fd0417 Compare June 3, 2025 16:14
@IgorIgnatevBolt
Copy link
Author

All commits were squashed into one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants