Updates Kubelet Plugin Registration process

[claudiubelu]

What type of PR is this?

/kind failing-test
/kind bug

/sig windows
/sig testing

/priority important-soon
/milestone v1.27

What this PR does / why we need it:

Currently, when a Kubelet Plugin is being added in the DesiredStateOfWorld, a timestamp is saved in the PluginInfo. This timestamp is then updated on subsequent plugin reregistrations.

The Reconciler, when it detects different timestamps for a Plugin in its DesiredStateOfWorld and ActualStateOfWorld, it will then trigger a Plugin unregister and then a new Plugin registration.

Basically, the timestamp is being used to detect whether or not a Plugin needs to be reregistered or not. However, this can be an issue on Windows, where the time measurements are not as fine-grained. time.Now() calls within the same ~1-15ms window will have the same timestamp. This can mean that Plugin Reregistration events can be missed on Windows [1]. Because of this, some of the Plugin registration unit tests fail on Windows.

This commit updates the behaviour, instead of relying on different timestamps, the Reconciler will check the set PluginInfo UUID to detect a Plugin Reregistration. With this change, the unit tests mentioned above will also pass on Windows.

[1] golang/go#8687

Which issue(s) this PR fixes:

Related: #51540

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubelet Plugins are now re-registered properly  on Windows if the re-registration period is < 15ms.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Nov 25 09:34:34 UTC 2022.

[jsturtevant]

/triage accepted

[SergeyKanzhelev]

/assign

[claudiubelu]

/test pull-ci-kubernetes-unit-windows

[claudiubelu]

@SergeyKanzhelev, have you had a change to review this?

[bart0sh]

/sig-storage

[bart0sh]

/sig storage

[claudiubelu]

/assign @saad-ali

[claudiubelu]

@SergeyKanzhelev, did you have a chance to look over this?

[pacoxu]

clear the milestone as it has no update for week.
/milestone v1.31
Hope we can make it in next release cycle.
As this is a bugfix, we may backport it later.

[claudiubelu]

/test pull-ci-kubernetes-unit-windows

[claudiubelu]

/test pull-ci-kubernetes-unit-windows

[claudiubelu]

/test pull-ci-kubernetes-unit-windows

[Vyom-Yadav]

Hello @claudiubelu ! This PR has not been updated for a long time, so I'd like to check what's the status. The code freeze is starting 02:00 UTC Wednesday 10th July 2024 (about 4 weeks from now), and while there is still plenty of time, we want to ensure that each PR has a chance to be merged on time.

As the PR is tagged for 1.31, is it still planned for this release?

[claudiubelu]

Hello @claudiubelu ! This PR has not been updated for a long time, so I'd like to check what's the status. The code freeze is starting 02:00 UTC Wednesday 10th July 2024 (about 4 weeks from now), and while there is still plenty of time, we want to ensure that each PR has a chance to be merged on time.

As the PR is tagged for 1.31, is it still planned for this release?

Hasn't been updated because I got no reviews. Waiting for those.

FWIW, it seems the unit tests are passing on Windows as well.

[Vyom-Yadav]

Hello @claudiubelu,

This PR hasn't been updated in a while. What's the current status? Do you want us to reach out to the folks who are supposed to review this?

Reminder: Code freeze starts 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024 (about 1 week from now). Please make sure the PR has both lgtm and approved labels before the code freeze.

[Vyom-Yadav]

/milestone clear
We are way past the code freeze. Please add the milestone for the next release if you'd like to target that.

[SergeyKanzhelev]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 2d53f15313565741c0b29f20e6b17d6202bfe688

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/pluginmanager/OWNERS [SergeyKanzhelev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@claudiubelu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-verify-lint	2604d7d	link	unknown	/test pull-kubernetes-verify-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.