Restore honoring --version build ID overrides

[liggitt]

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Minimal fix to restore honoring --version build ID overrides for 1.31

Added a simple test around the behavior at the start of test-cmd, where we're starting a real built API server

Which issue(s) this PR fixes:

Fixes #126663

Does this PR introduce a user-facing change?

kube-apiserver: Fixes a 1.31 regression that stopped honoring build ID overrides with the --version flag

/sig api-machinery
/assign @jpbetz
/hold for tests

[liggitt]

/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• hack/OWNERS [liggitt]
• staging/src/k8s.io/apiserver/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

+++ [0814 00:59:07] On try 4, apiserver: ok
Successful
�(Bmessage:{
  "major": "1",
  "minor": "32",
  "gitVersion": "v1.32.0-alpha.0.34+67202bdb1d4932-custom",
  "gitCommit": "67202bdb1d49321b05481461725b326a072960b8",
  "gitTreeState": "clean",
  "buildDate": "2024-08-13T21:44:43Z",
  "goVersion": "go1.22.5",
  "compiler": "gc",
  "platform": "linux/amd64"
}
has:gitVersion.*-custom

test passed

[liggitt]

/hold cancel

This will need revisiting if we actually start letting people override the binary version (I'm not sure if that's planned or not), but this is a minimal version to resolve the regression for 1.31

[BenTheElder]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e372f454319f7f7ccad42f5a3d7fb1c8ca07d734

[BenTheElder]

/lgtm
[discussed shellcheck fix, see diff link above in "compare" button]

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: a6fceb3bd5e09b67f0333bef9b022f6ab48ed61d

[liggitt]

/priority important-soon
/triage accepted