KEP-4222: Add CBOR feature gates. #128539
Merged
+918
−296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
sig/testing
k8s-ci-robot
requested review from
deads2k,
jpbetz,
alculquicondor and
caesarxuchao
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
98 tasks
|
/lgtm /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 357fa09dcef6ca40568361ab83c31dc73ad8a5ea
|
benluddy
force-pushed
the
cbor-feature-gates
branch
from
aba1a32 to
66b59c9
Compare
k8s-ci-robot
removed
the
lgtm
59 tasks
|
Is there a (placeholder) PR to the website for this feature gate? |
|
k8s-ci-robot
added
the
sig/etcd
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, deads2k, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
For alpha, there is one apiserver feature gate and two client-go feature gates controlling CBOR. They were initially wired to separate test-only feature gate instances in order to prevent them from being configurable at runtime via command-line flags or environment variables (for client-go feature gates outside of Kubernetes components). All of the integration tests required by the KEP as alpha criteria have been implemented. This adds the feature gates to the usual feature gate instances and removes the temporary code to support separate test-only feature gate instances.
benluddy
force-pushed
the
cbor-feature-gates
branch
from
ebe7370 to
c42de7f
Compare
|
/hold cancel #128462 has merged. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2515126a01b5be807c9db9c03a732dd99f6a825e
|
Setting AllAlpha=true in integration tests changes the dynamic client request encoding and the custom resource storage encoding to CBOR. The etcd storage path is updated to accept either JSON or CBOR as storage encoding. The client feature gate controlling the dynamic client request encoding is temporarily disabled until the serving codecs for builtin APIs are wired to the CBOR apiserver feature gate.
benluddy
force-pushed
the
cbor-feature-gates
branch
from
c42de7f to
88c9dd7
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5d5110cd09b6ac6eecb01023a98393c28a1bde3c
|
This was referenced Nov 5, 2024
aojea
reviewed
Nov 6, 2024
Comment on lines
+45
to
+50
| // If enabled, and only if ClientsAllowCBOR is also enabled, the default request content | ||
| // type (if not explicitly configured) and the dynamic client's request content type both | ||
| // become "application/cbor" instead of "application/json". The default content type for | ||
| // apply patch requests becomes "application/apply-patch+cbor" instead of | ||
| // "application/apply-patch+yaml". | ||
| ClientsPreferCBOR Feature = "ClientsPreferCBOR" |
There was a problem hiding this comment.
This seems to cause the issues here #128600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/sig api-machinery
What this PR does / why we need it:
For alpha, there is one apiserver feature gate and two client-go feature gates controlling CBOR. They were initially wired to separate test-only feature gate instances in order to prevent them from being configurable at runtime via command-line flags or environment variables (for client-go feature gates outside of Kubernetes components). All of the integration tests required by the KEP as alpha criteria have been implemented. This adds the feature gates to the usual feature gate instances and removes the temporary code to support separate test-only feature gate instances.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR excludes wiring the codecs used for serving built-in API resources (by request from @deads2k). That will follow before 1.32 code freeze.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: