Skip to content

Automated cherry pick of #129599: Automated cherry pick of #129595: kubelet: use env vars in node log query PS command #129603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

Automated cherry pick of #129599: Automated cherry pick of #129595: kubelet: use env vars in node log query PS command #129603

merged 1 commit into from
Jan 14, 2025

Conversation

aravindhp
Copy link
Contributor

Cherry pick of #129599 on release-1.29.

#129599: Automated cherry pick of #129595: kubelet: use env vars in node log query PS command

For details on the cherry pick process, see the cherry pick requests page.

NONE

@aravindhp
kubelet: use env vars in node log query PS command
1e45808 
- Use environment variables to pass string arguments in the node log
  query PS command
- Split getLoggingCmd into getLoggingCmdEnv and getLoggingCmdArgs
  for better modularization
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Jan 14, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/code-generation labels Jan 14, 2025
@k8s-ci-robot k8s-ci-robot added area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 14, 2025
@aravindhp
Copy link
Contributor Author

/cc @mrunalp @marosset @jsturtevant @liggitt @SaranBalaji90

@aravindhp
Copy link
Contributor Author

/test pull-kubernetes-typecheck

@aravindhp
Copy link
Contributor Author

/test pull-kubernetes-verify

@marosset
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa2f69585138e4a9a02ef55d52b8b4d08f0c78f5

@liggitt
Copy link
Member

liggitt commented Jan 14, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@aravindhp
Copy link
Contributor Author

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 14, 2025
xmudrii
xmudrii approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, liggitt, marosset, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fb0187c into kubernetes:release-1.29 Jan 14, 2025
16 checks passed
@aravindhp aravindhp deleted the automated-cherry-pick-of-#129599-upstream-release-1.29 branch January 14, 2025 19:28
@SaranBalaji90 SaranBalaji90 mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@justinsb justinsb Awaiting requested review from justinsb

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@liggitt liggitt Awaiting requested review from liggitt

@marosset marosset Awaiting requested review from marosset

@mrunalp mrunalp Awaiting requested review from mrunalp

@SaranBalaji90 SaranBalaji90 Awaiting requested review from SaranBalaji90

Assignees

@liggitt liggitt

@marosset marosset

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@aravindhp @marosset @k8s-ci-robot @liggitt @xmudrii