-
Notifications
You must be signed in to change notification settings - Fork 40.4k
chore(scheduler): add filter integration tests for missing part plugins: NodeResources plugin #130375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(scheduler): add filter integration tests for missing part plugins: NodeResources plugin #130375
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1556b60
to
b46629a
Compare
@haosdent: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/sig scheduling |
c40eb9e
to
552339b
Compare
/cc @macsko @sanposhiho |
}).Container(pause). | ||
Obj(), | ||
}, | ||
incomingPod: st.MakePod().Name("insufficient-incoming-pod"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make the incomingPod schedulable if the existingPod would not exist, e.g.
node: 3 CPU
existingPod: 2 CPU
incomingPod: 2 CPU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to change the pod does not fit due to insufficient node resources
test to:
node: st.MakeNode().Name("insufficient-node").Capacity(
map[v1.ResourceName]string{
v1.ResourceCPU: "3",
v1.ResourceMemory: "3G",
}).Obj(),
existingPod: st.MakePod().Name("insufficient-existing-pod").
Res(map[v1.ResourceName]string{
v1.ResourceCPU: "2",
v1.ResourceMemory: "2G",
}).Container(pause).
Obj(),
incomingPod: st.MakePod().Name("insufficient-incoming-pod").
Res(map[v1.ResourceName]string{
v1.ResourceCPU: "2",
v1.ResourceMemory: "2G",
}).Container(pause).
Obj(),
fit: false,
Then we will see if the existingPod is really taken into account by the plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I missunstand, done
pause := imageutils.GetPauseImageName() | ||
tests := []struct { | ||
name string | ||
nodes []*v1.Node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it a single node, not slice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same with existingPods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/remove-kind feature |
c14f8d5
to
a8fe1f8
Compare
a8fe1f8
to
364fec1
Compare
…ns: NodeResources plugin
364fec1
to
ca42add
Compare
/lgtm |
LGTM label has been added. Git tree hash: b9f348b01e0d681db87a75f2bc20c17bfb161fc6
|
/test pull-kubernetes-e2e-kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: googs1025, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes part of #129856
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: