Skip to content

Remove an asterix from the path parameter #14049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2015
Merged

Remove an asterix from the path parameter #14049

merged 1 commit into from
Sep 17, 2015

Conversation

brendandburns
Copy link
Contributor

@k8s-bot
Copy link

k8s-bot commented Sep 16, 2015

GCE e2e build/test passed for commit 3153c25.

@bgrant0607
Copy link
Member

cc @kubernetes/goog-csi

@nikhiljindal
Copy link
Contributor

All tests pass but am not sure if we have a test for an operation with {path:}.
Can you please make sure once that those operations continue working fine after this change, for ex you can try: /api/v1/proxy/nodes/{name}/{path:}
Thanks!

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@brendandburns
Copy link
Contributor Author

@nikhiljindal

We test it in e2e:

https://github.com/kubernetes/kubernetes/blob/master/test/e2e/proxy.go#L217

And that e2e test has passed in the PR builder run.

@nikhiljindal
Copy link
Contributor

Awesome, thanks!
LGTM

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2015
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 17, 2015

GCE e2e build/test passed for commit 3153c25.

@k8s-github-robot
Copy link

Automatic merge from SubmitQueue

k8s-github-robot pushed a commit that referenced this pull request Sep 17, 2015
Merge pull request #14049 from brendandburns/apiserver2
3b221fb 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 3b221fb into kubernetes:master Sep 17, 2015
@nikhiljindal nikhiljindal mentioned this pull request Nov 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@brendandburns @k8s-bot @bgrant0607 @nikhiljindal @k8s-github-robot @googlebot @alex-mohr