Skip to content

Commit cb8c008

Browse files
authored
Merge pull request #13080 from sgmac/kubernetes-version-newest
Accept "newest" as input for --kubernetes-version
2 parents e9f6d8d + de37996 commit cb8c008

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

Diff for: cmd/minikube/cmd/start.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -1577,7 +1577,7 @@ $ minikube config unset kubernetes-version`)
15771577

15781578
if paramVersion == "" || strings.EqualFold(paramVersion, "stable") {
15791579
paramVersion = constants.DefaultKubernetesVersion
1580-
} else if strings.EqualFold(paramVersion, "latest") {
1580+
} else if strings.EqualFold(strings.ToLower(paramVersion), "latest") || strings.EqualFold(strings.ToLower(paramVersion), "newest") {
15811581
paramVersion = constants.NewestKubernetesVersion
15821582
}
15831583

Diff for: cmd/minikube/cmd/start_test.go

+15
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,21 @@ func TestGetKubernetesVersion(t *testing.T) {
7373
expectedVersion: constants.NewestKubernetesVersion,
7474
paramVersion: "latest",
7575
},
76+
{
77+
description: "kubernetes-version given as 'LATEST', no config",
78+
expectedVersion: constants.NewestKubernetesVersion,
79+
paramVersion: "LATEST",
80+
},
81+
{
82+
description: "kubernetes-version given as 'newest', no config",
83+
expectedVersion: constants.NewestKubernetesVersion,
84+
paramVersion: "newest",
85+
},
86+
{
87+
description: "kubernetes-version given as 'NEWEST', no config",
88+
expectedVersion: constants.NewestKubernetesVersion,
89+
paramVersion: "NEWEST",
90+
},
7691
}
7792

7893
for _, test := range tests {

0 commit comments

Comments
 (0)