Skip to content

Accept "newest" as input for --kubernetes-version #13080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

sgmac
Copy link
Contributor

@sgmac sgmac commented Dec 3, 2021

Adds support for #13076

Testing

 ./out/minikube start -p testin1 --kubernetes-version=newest
* [testin1] minikube v1.24.0 on Ubuntu 20.04
* Automatically selected the docker driver. Other choices: kvm2, virtualbox, none, ssh
* Starting control plane node testin1 in cluster testin1
* Pulling base image ...
* Downloading Kubernetes v1.23.0-beta.0 preload ...
    > preloaded-images-k8s-v14-v1...: 506.33 MiB / 506.33 MiB  100.00% 25.33 Mi
    > gcr.io/k8s-minikube/kicbase: 355.78 MiB / 355.78 MiB  100.00% 9.17 MiB p/
* Creating docker container (CPUs=2, Memory=16000MB) ...
* Preparing Kubernetes v1.23.0-beta.0 on Docker 20.10.8 ...
  - Generating certificates and keys ...
  - Booting up control plane ...
  - Configuring RBAC rules ...
* Verifying Kubernetes components...
  - Using image gcr.io/k8s-minikube/storage-provisioner:v5
* Enabled addons: default-storageclass, storage-provisioner
* Done! kubectl is now configured to use "testin1" cluster and "default" namespace by default

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @sgmac!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @sgmac. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sgmac
To complete the pull request process, please assign sharifelgamal after the PR has been reviewed.
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sgmac sgmac changed the title Support newest for --kubernetest-version Support newest for --kubernetes-version Dec 3, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2021
@sgmac sgmac force-pushed the kubernetes-version-newest branch from 45df565 to 5cf35c6 Compare December 3, 2021 21:33
Signed-off-by: Sergio Galvan <[email protected]>
@sgmac sgmac force-pushed the kubernetes-version-newest branch from 5cf35c6 to de37996 Compare December 3, 2021 21:35
@medyagh medyagh changed the title Support newest for --kubernetes-version Accept "newest" for --kubernetes-version Dec 3, 2021
@medyagh
Copy link
Member

medyagh commented Dec 3, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2021
@medyagh medyagh self-requested a review December 3, 2021 21:44
@medyagh medyagh changed the title Accept "newest" for --kubernetes-version Accept "newest" as input for --kubernetes-version Dec 3, 2021
@medyagh medyagh merged commit cb8c008 into kubernetes:master Dec 3, 2021
@medyagh
Copy link
Member

medyagh commented Dec 3, 2021

Thank you for this pr

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13080) |
+----------------+----------+---------------------+
| minikube start | 46.5s    | 46.2s               |
| enable ingress | 30.7s    | 30.4s               |
+----------------+----------+---------------------+

Times for minikube start: 46.5s 45.8s 47.6s 45.8s 46.6s
Times for minikube (PR 13080) start: 45.3s 47.4s 46.1s 46.7s 45.5s

Times for minikube ingress: 31.2s 31.3s 30.3s 30.8s 29.7s
Times for minikube (PR 13080) ingress: 31.8s 29.2s 30.3s 30.3s 30.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13080) |
+----------------+----------+---------------------+
| minikube start | 21.1s    | 20.9s               |
| enable ingress | 27.0s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.4s 26.4s 25.9s 27.4s 27.9s
Times for minikube (PR 13080) ingress: 26.9s 26.9s 26.9s 33.4s 26.4s

Times for minikube start: 20.6s 20.7s 20.9s 21.1s 21.9s
Times for minikube (PR 13080) start: 20.9s 21.3s 20.8s 21.5s 20.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13080) |
+----------------+----------+---------------------+
| minikube start | 38.5s    | 34.7s               |
| enable ingress | 32.4s    | 29.8s               |
+----------------+----------+---------------------+

Times for minikube start: 24.1s 43.9s 41.0s 41.6s 41.6s
Times for minikube (PR 13080) start: 25.2s 41.8s 24.4s 41.0s 41.2s

Times for minikube ingress: 32.9s 28.9s 26.9s 28.9s 44.4s
Times for minikube (PR 13080) ingress: 61.9s 18.9s 31.9s 17.9s 18.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Localhost (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/newest-cni/serial/Pause (gopogh) 3.21 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 5.11 (chart)
none_Linux TestFunctional/serial/ComponentHealth (gopogh) 8.33 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 8.70 (chart)
Docker_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 8.76 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 8.76 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 11.68 (chart)
Docker_Windows TestPause/serial/PauseAgain (gopogh) 11.96 (chart)
Docker_macOS TestNoKubernetes/serial/ProfileList (gopogh) 13.14 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 13.14 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 13.14 (chart)
Docker_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 13.14 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 13.14 (chart)
Docker_macOS TestPause/serial/Unpause (gopogh) 13.14 (chart)
Docker_macOS TestPause/serial/VerifyDeletedResources (gopogh) 13.14 (chart)
Docker_macOS TestPause/serial/Pause (gopogh) 13.87 (chart)
Docker_macOS TestPause/serial/PauseAgain (gopogh) 13.87 (chart)
Docker_macOS TestPause/serial/VerifyStatus (gopogh) 13.87 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 15.05 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 15.70 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 15.70 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 15.70 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 16.06 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 16.53 (chart)
Hyper-V_Windows TestErrorSpam/setup (gopogh) 17.32 (chart)
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 22.83 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 23.77 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 24.68 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 24.68 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants