Skip to content

Fix go bump automation to adopt Kubernetes new kube-cross image name #12375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 30, 2021

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Aug 30, 2021

closes #12374

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@medyagh medyagh changed the title update go bump version logic to match kubernetes new image for kube cross Fix go bump automation to adopt Kubernete's new kube-cross image name Aug 30, 2021
@sharifelgamal
Copy link
Collaborator

do we have to care about older versions of golang that doesn't have the k8sversion prefix?

@sharifelgamal sharifelgamal changed the title Fix go bump automation to adopt Kubernete's new kube-cross image name Fix go bump automation to adopt Kubernetes new kube-cross image name Aug 30, 2021
@medyagh
Copy link
Member Author

medyagh commented Aug 30, 2021

do we have to care about older versions of golang that doesn't have the k8sversion prefix?

no since we are not automating older versions

@medyagh medyagh merged commit 0f7be4f into kubernetes:master Aug 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh deleted the fix_go_auto branch May 27, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bump golang version logic after Kube-cross image change
3 participants