Fix disabling gcp-auth addon and test #12779

sharifelgamal · 2021-10-26T01:23:48Z

disabling the gcp-auth addon was broken, since we were never running the kubectl delete command
the gcp-auth test is smarter now, since GCE machines should automatically have access to the private images in the test manifests
we no longer need to supply --force to the addons enable in the test since we are explicitly supplying the correct env vars

sharifelgamal · 2021-10-26T19:12:03Z

/ok-to-test

…ng the addon

minikube-pr-bot · 2021-10-26T20:11:15Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 47.6s    | 46.2s               |
| enable ingress | 31.5s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube start: 49.6s 47.0s 47.9s 47.1s 46.3s
Times for minikube (PR 12779) start: 45.9s 46.1s 46.6s 46.1s 46.3s

Times for minikube ingress: 32.0s 32.3s 31.7s 31.2s 30.4s
Times for minikube (PR 12779) ingress: 32.3s 32.8s 30.7s 31.7s 30.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.3s               |
| enable ingress | 32.5s    | 34.6s               |
+----------------+----------+---------------------+

Times for minikube start: 22.4s 21.0s 21.1s 21.8s 21.5s
Times for minikube (PR 12779) start: 20.9s 21.3s 22.3s 20.6s 21.4s

Times for minikube ingress: 27.9s 27.4s 28.4s 34.0s 44.9s
Times for minikube (PR 12779) ingress: 34.4s 34.4s 35.4s 35.0s 33.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 40.1s    | 43.5s               |
| enable ingress | 29.9s    | 34.4s               |
+----------------+----------+---------------------+

Times for minikube start: 32.3s 44.0s 44.2s 36.4s 43.7s
Times for minikube (PR 12779) start: 43.9s 42.9s 42.8s 43.8s 44.0s

Times for minikube ingress: 33.0s 23.9s 32.9s 26.9s 32.9s
Times for minikube (PR 12779) ingress: 20.4s 33.9s 23.9s 61.4s 32.5s

minikube-pr-bot · 2021-10-26T20:50:45Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 46.9s               |
| enable ingress | 31.7s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.8s 30.3s 33.9s 31.3s 31.3s
Times for minikube (PR 12779) ingress: 32.2s 32.2s 31.3s 31.8s 32.3s

Times for minikube (PR 12779) start: 46.2s 47.2s 46.9s 47.0s 47.1s
Times for minikube start: 47.9s 47.4s 48.5s 48.1s 46.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.8s               |
| enable ingress | 33.0s    | 34.2s               |
+----------------+----------+---------------------+

Times for minikube start: 22.0s 22.2s 21.1s 20.8s 22.3s
Times for minikube (PR 12779) start: 21.0s 21.9s 22.1s 21.0s 22.7s

Times for minikube ingress: 31.4s 35.4s 35.4s 28.4s 34.5s
Times for minikube (PR 12779) ingress: 34.9s 26.4s 35.9s 34.9s 38.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 45.3s    | 39.8s               |
| enable ingress | 30.7s    | 37.3s               |
+----------------+----------+---------------------+

Times for minikube start: 46.8s 44.0s 43.8s 44.0s 48.0s
Times for minikube (PR 12779) start: 26.4s 43.3s 42.9s 42.7s 43.6s

Times for minikube ingress: 28.4s 32.9s 23.4s 36.5s 32.5s
Times for minikube (PR 12779) ingress: 33.4s 63.9s 26.9s 32.9s 29.5s

k8s-ci-robot · 2021-10-26T21:36:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2021-10-26T22:10:34Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 47.4s    | 47.8s               |
| enable ingress | 31.2s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 30.3s 32.0s 31.2s 31.3s 31.4s
Times for minikube (PR 12779) ingress: 31.2s 31.3s 33.9s 30.8s 31.2s

Times for minikube (PR 12779) start: 47.7s 49.3s 47.8s 46.3s 47.7s
Times for minikube start: 49.3s 47.5s 46.3s 47.4s 46.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 21.3s    | 21.7s               |
| enable ingress | 31.4s    | 37.9s               |
+----------------+----------+---------------------+

Times for minikube start: 21.8s 20.3s 21.2s 22.1s 21.2s
Times for minikube (PR 12779) start: 21.2s 21.6s 21.6s 23.3s 21.0s

Times for minikube ingress: 34.4s 35.4s 26.4s 33.9s 26.9s
Times for minikube (PR 12779) ingress: 26.4s 28.4s 26.4s 82.4s 25.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 39.9s    | 41.6s               |
| enable ingress | 32.8s    | 34.7s               |
+----------------+----------+---------------------+

Times for minikube start: 27.2s 43.6s 42.7s 43.4s 42.6s
Times for minikube (PR 12779) start: 43.2s 35.8s 42.4s 43.5s 42.9s

Times for minikube ingress: 32.4s 32.9s 32.9s 32.9s 32.9s
Times for minikube (PR 12779) ingress: 32.9s 36.4s 32.9s 18.6s 52.4s

minikube-pr-bot · 2021-10-26T23:03:57Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
none_Linux	TestAddons/serial/GCPAuth (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/Pause (gopogh)	1.96 (chart)
Docker_Linux	TestFunctional/serial/ComponentHealth (gopogh)	5.88 (chart)
KVM_Linux	TestAddons/serial/GCPAuth (gopogh)	41.13 (chart)
Docker_Linux_containerd	TestAddons/serial/GCPAuth (gopogh)	45.75 (chart)
Docker_Linux	TestAddons/serial/GCPAuth (gopogh)	45.75 (chart)
KVM_Linux_containerd	TestAddons/serial/GCPAuth (gopogh)	48.78 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

sharifelgamal · 2021-10-26T23:31:24Z

/ok-to-test

minikube-pr-bot · 2021-10-27T01:00:24Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	2.08 (chart)
KVM_Linux	TestAddons/serial/GCPAuth (gopogh)	44.70 (chart)
Docker_Linux_containerd	TestAddons/serial/GCPAuth (gopogh)	49.31 (chart)
Docker_Linux	TestAddons/serial/GCPAuth (gopogh)	49.31 (chart)
KVM_Linux_containerd	TestAddons/serial/GCPAuth (gopogh)	52.60 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)
Hyper-V_Windows	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Hyper-V_Windows	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-10-27T01:16:28Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 47.3s    | 46.6s               |
| enable ingress | 31.1s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube start: 47.3s 46.8s 48.1s 46.9s 47.6s
Times for minikube (PR 12779) start: 46.0s 46.7s 46.4s 46.7s 47.0s

Times for minikube ingress: 30.8s 33.3s 30.7s 31.3s 29.2s
Times for minikube (PR 12779) ingress: 31.2s 31.3s 32.3s 30.8s 32.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 21.0s    | 21.3s               |
| enable ingress | 26.6s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 20.8s 20.7s 20.6s 20.8s
Times for minikube (PR 12779) start: 21.9s 20.2s 21.0s 20.9s 22.7s

Times for minikube ingress: 25.9s 26.4s 26.9s 26.4s 27.4s
Times for minikube (PR 12779) ingress: 26.5s 26.4s 26.4s 27.9s 30.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12779) |
+----------------+----------+---------------------+
| minikube start | 43.9s    | 43.8s               |
| enable ingress | 31.1s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube start: 44.5s 43.2s 44.1s 44.3s 43.3s
Times for minikube (PR 12779) start: 43.1s 44.1s 44.8s 42.9s 43.9s

Times for minikube ingress: 28.9s 32.9s 32.9s 28.5s 32.5s
Times for minikube (PR 12779) ingress: 32.9s 18.4s 32.4s 32.9s 19.4s

minikube-pr-bot · 2021-10-27T05:33:47Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyper-V_Windows	TestPause/serial/Pause (gopogh)	3.92 (chart)
Hyper-V_Windows	TestPause/serial/VerifyStatus (gopogh)	3.92 (chart)
Docker_Linux_containerd	TestPause/serial/Pause (gopogh)	15.17 (chart)
Docker_Linux_containerd	TestPause/serial/VerifyStatus (gopogh)	15.17 (chart)
Docker_Linux_containerd	TestPause/serial/PauseAgain (gopogh)	25.52 (chart)
Docker_Windows	TestMountStart/serial/StartWithMountFirst (gopogh)	65.14 (chart)
Docker_Windows	TestMountStart/serial/StartWithMountSecond (gopogh)	65.14 (chart)
Docker_Windows	TestMountStart/serial/VerifyMountFirst (gopogh)	65.14 (chart)
Docker_Windows	TestMountStart/serial/VerifyMountPostDelete (gopogh)	65.14 (chart)
Docker_Windows	TestMountStart/serial/VerifyMountSecond (gopogh)	65.14 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	69.57 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	80.43 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)
Docker_Windows	TestMountStart/serial/RestartStopped (gopogh)	100.00 (chart)
Docker_Windows	TestMountStart/serial/Stop (gopogh)	100.00 (chart)
Docker_Windows	TestMountStart/serial/VerifyMountPostStop (gopogh)	100.00 (chart)
Docker_Windows	TestPause/serial/VerifyDeletedResources (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)
Hyper-V_Windows	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Hyper-V_Windows	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

sharifelgamal added 6 commits October 21, 2021 17:04

fix gcp-auth tests to avoid expiring tokens

5b53ae8

manually set and unset the env var again

f8db8f0

fix disabling gcp-auth addon

bec0381

reverse files for kubectl remove on addon disable

bd9da42

ignore-not-found for kubectl delete

b0598d0

cleanup and comments

1e932bc

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2021

k8s-ci-robot requested review from medyagh and spowelljr October 26, 2021 01:24

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2021

sharifelgamal changed the title ~~Fix disabling gcp-auth addon and test~~ WIP: Fix disabling gcp-auth addon and test Oct 26, 2021

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2021

sharifelgamal added 4 commits October 26, 2021 08:50

fix lint

2ed63b6

fix unit test

77da350

fix unit test part deux

aaf8503

no need to reverse file order for kubectl delete

8cf0a18

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 26, 2021

don't run disable on final gcp-auth enable, we're not actually enabli…

144ebe6

…ng the addon

fix expected test output

67f3149

sharifelgamal changed the title ~~WIP: Fix disabling gcp-auth addon and test~~ Fix disabling gcp-auth addon and test Oct 26, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2021

medyagh approved these changes Oct 26, 2021

View reviewed changes

kubernetes deleted a comment from minikube-pr-bot Oct 26, 2021

sharifelgamal merged commit 418a9a1 into kubernetes:master Oct 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix disabling gcp-auth addon and test #12779

Fix disabling gcp-auth addon and test #12779

Uh oh!

sharifelgamal commented Oct 26, 2021 •

edited

Loading

Uh oh!

sharifelgamal commented Oct 26, 2021

Uh oh!

minikube-pr-bot commented Oct 26, 2021

Uh oh!

minikube-pr-bot commented Oct 26, 2021

Uh oh!

k8s-ci-robot commented Oct 26, 2021

Uh oh!

minikube-pr-bot commented Oct 26, 2021

Uh oh!

minikube-pr-bot commented Oct 26, 2021

Uh oh!

sharifelgamal commented Oct 26, 2021

Uh oh!

minikube-pr-bot commented Oct 27, 2021

Uh oh!

minikube-pr-bot commented Oct 27, 2021

Uh oh!

minikube-pr-bot commented Oct 27, 2021

Uh oh!

Uh oh!

Fix disabling gcp-auth addon and test #12779

Fix disabling gcp-auth addon and test #12779

Uh oh!

Conversation

sharifelgamal commented Oct 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sharifelgamal commented Oct 26, 2021

Uh oh!

minikube-pr-bot commented Oct 26, 2021

Uh oh!

minikube-pr-bot commented Oct 26, 2021

Uh oh!

k8s-ci-robot commented Oct 26, 2021

Uh oh!

minikube-pr-bot commented Oct 26, 2021

Uh oh!

minikube-pr-bot commented Oct 26, 2021

Uh oh!

sharifelgamal commented Oct 26, 2021

Uh oh!

minikube-pr-bot commented Oct 27, 2021

Uh oh!

minikube-pr-bot commented Oct 27, 2021

Uh oh!

minikube-pr-bot commented Oct 27, 2021

Uh oh!

Uh oh!

sharifelgamal commented Oct 26, 2021 •

edited

Loading