-
Notifications
You must be signed in to change notification settings - Fork 5k
Add --no-kubernetes flag to start minikube without kubernetes #12848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+188
โ15
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
79f1b8c
add --no-kubernetes flag to start minikube without kubernetes
medyagh c827bf8
better name
medyagh 3d0f486
add integration test for --no-kubernetes
medyagh bfdc3cf
address review comments
medyagh cd9d263
address review comments
medyagh 5bcdba0
add more constants
medyagh d3ec072
Update test/integration/no_kubernetes.go
medyagh 47307d7
Update test/integration/no_kubernetes.go
medyagh 51e612f
Update test/integration/no_kubernetes.go
medyagh 1200c8e
Update test/integration/no_kubernetes.go
medyagh f54f95d
Update test/integration/no_kubernetes.go
medyagh e15065a
Update test/integration/no_kubernetes.go
medyagh 0ef4fc5
Update test/integration/no_kubernetes.go
medyagh 6806e69
fix integration test file name
medyagh 630e02d
Update cmd/minikube/cmd/start.go
medyagh a108c71
remove comment
medyagh 92cf41d
do not set global viper config
medyagh 75e6ba6
better translate
medyagh f2c743d
skip test on none
medyagh f405565
spell
medyagh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check for the runtime being docker, so needs a parameter with the current setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actualy aware of this I was gonna make a good first issue out of this for joey