Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update addon files to use fully qualified name #14521

Merged
merged 28 commits into from
Aug 12, 2022
Merged

Update addon files to use fully qualified name #14521

merged 28 commits into from
Aug 12, 2022

Conversation

siddhant-khisty
Copy link
Contributor

Updated the files in deploy/addons/aliyun_mirror.json
As the issue mentions files have to be changed in pkg/minikube/assets/addons.go as well, but I don't see anything that needs to be changed. Please let me know if I'm missing something.

fixes #14520

@k8s-ci-robot
Copy link
Contributor

Welcome @SiddhantKhisty!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @SiddhantKhisty. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 7, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 7, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 7, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

Hi @SiddhantKhisty, you'll need to sign the CLA as outlined in the comments above, thanks

@siddhant-khisty
Copy link
Contributor Author

@spowelljr hi, I just finished signing the CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 7, 2022
@siddhant-khisty
Copy link
Contributor Author

Hey @spowelljr, Sorry about that. I misunderstood the previous comment. I have a question though. Does the Registry on line 368 refer to the Docker hub registries?

Also, I'm not sure how I should rebase this branch. Can we look into that once you've confirmed that no changes are needed?

__
sema-logo  Summary: ❓ I have a question

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2022
@spowelljr
Copy link
Member

spowelljr commented Jul 26, 2022 •
edited
Loading

Hi @siddhant-khisty, yes registry is from Docker Hub (https://hub.docker.com/_/registry).

And I resolved the rebase, I helped the person with that PR so I knew what changed so I handled it for you.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2022
@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14521) |
+----------------+----------+---------------------+
| minikube start | 56.3s    | 56.3s               |
| enable ingress | 28.9s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube start: 56.6s 55.2s 57.0s 58.6s 54.2s
Times for minikube (PR 14521) start: 57.4s 56.1s 56.1s 56.0s 56.1s

Times for minikube ingress: 28.6s 29.6s 30.1s 26.1s 30.0s
Times for minikube (PR 14521) ingress: 25.1s 26.1s 29.1s 27.1s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14521) |
+----------------+----------+---------------------+
| minikube start | 28.1s    | 27.6s               |
| enable ingress | 22.0s    | 23.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.5s 21.5s 22.0s 22.0s 22.0s
Times for minikube (PR 14521) ingress: 23.9s 23.0s 22.5s 23.0s 22.9s

Times for minikube start: 26.9s 29.8s 29.0s 27.9s 27.1s
Times for minikube (PR 14521) start: 27.6s 27.7s 27.4s 26.6s 28.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14521) |
+----------------+----------+---------------------+
| minikube start | 26.0s    | 23.2s               |
| enable ingress | 26.7s    | 26.7s               |
+----------------+----------+---------------------+

Times for minikube start: 24.0s 24.3s 35.0s 22.9s 23.9s
Times for minikube (PR 14521) start: 23.2s 23.4s 23.1s 22.9s 23.3s

Times for minikube ingress: 26.5s 26.5s 27.4s 26.4s 26.5s
Times for minikube (PR 14521) ingress: 27.5s 27.4s 26.5s 26.4s 25.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Hyper-V_Windows TestAddons/Setup (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/parallel/ServiceCmdConnect (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/CacheCmd/cache/add_local (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/CacheCmd/cache/add_remote (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/CacheCmd/cache/delete (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/CacheCmd/cache/delete_k8s.gcr.io/pause (gopogh) 3.3 (chart)
Hyper-V_Windows TestFunctional/serial/CacheCmd/cache/list (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/KubeContext (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/KubectlGetPods (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/MinikubeKubectlCmd (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/MinikubeKubectlCmdDirectly (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/StartWithProxy (gopogh) 0.00 (chart)
Hyper-V_Windows TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 0.00 (chart)
Hyper-V_Windows TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 0.00 (chart)
Hyper-V_Windows TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 0.00 (chart)
Hyper-V_Windows TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 0.00 (chart)
Hyper-V_Windows TestJSONOutput/pause/Command (gopogh) 0.00 (chart)
Hyper-V_Windows TestJSONOutput/start/Command (gopogh) 0.00 (chart)
Hyper-V_Windows TestJSONOutput/stop/Command (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member

spowelljr commented Jul 29, 2022 •
edited
Loading

Hi @siddhant-khisty, thanks for the changes! The tests have discovered that we have a bug in our code in relation to setting the Registries and setting custom images. I'm going to look into the issue and find a solution and then once that's resolved your PR will be good to merge.

@siddhant-khisty
Copy link
Contributor Author

oh cool. Is there any way I can help find what's wrong?

__
sema-logo  Summary: ❓ I have a question

@spowelljr spowelljr mentioned this pull request Aug 1, 2022
Merged
@spowelljr
Copy link
Member

Hi @siddhant-khisty, my PR was merged, could you rebase on master and push back up, thanks.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14521) |
+----------------+----------+---------------------+
| minikube start | 57.5s    | 58.2s               |
| enable ingress | 29.5s    | 29.8s               |
+----------------+----------+---------------------+

Times for minikube start: 61.2s 57.4s 55.6s 56.6s 56.8s
Times for minikube (PR 14521) start: 56.5s 59.6s 56.8s 59.0s 59.3s

Times for minikube ingress: 29.7s 29.7s 28.7s 29.2s 30.2s
Times for minikube (PR 14521) ingress: 30.2s 29.2s 30.7s 29.2s 29.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14521) |
+----------------+----------+---------------------+
| minikube start | 28.6s    | 28.7s               |
| enable ingress | 23.7s    | 23.5s               |
+----------------+----------+---------------------+

Times for minikube start: 28.6s 28.7s 28.8s 28.0s 29.1s
Times for minikube (PR 14521) start: 28.3s 28.6s 28.3s 29.2s 29.1s

Times for minikube ingress: 26.5s 24.5s 23.0s 21.5s 23.0s
Times for minikube (PR 14521) ingress: 23.5s 22.5s 25.0s 23.5s 23.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14521) |
+----------------+----------+---------------------+
| minikube start | 27.1s    | 29.0s               |
| enable ingress | 27.0s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 14521) start: 35.0s 25.0s 24.3s 36.6s 24.1s
Times for minikube start: 25.4s 25.4s 24.6s 24.8s 35.1s

Times for minikube ingress: 27.0s 27.0s 27.0s 27.0s 27.0s
Times for minikube (PR 14521) ingress: 27.0s 27.0s 27.0s 27.0s 27.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestMultiNode/serial/RestartMultiNode (gopogh) 43.59 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 69.17 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 75.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 76.34 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 77.52 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 81.94 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 83.33 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 85.42 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 87.50 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 98.62 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/HairPin (gopogh) 100.00 (chart)
Docker_macOS TestPause/serial/VerifyStatus (gopogh) 100.00 (chart)
Docker_macOS TestPreload (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Pause (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/newest-cni/serial/Pause (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/no-preload/serial/Pause (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@siddhant-khisty
Copy link
Contributor Author

Hey @spowelljr, I synced my branch with master, but it seems that tests are still failing. Seems that the images are still not being found on the defined path.

__
sema-logo  Summary: 🛠️ This code needs a fix

@spowelljr
Copy link
Member

The tests look fine to me, the tests that are failing always fail so they're not a concern. Some of the tests environments didn't report back so I'm going to run them again.

@spowelljr
Copy link
Member

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14521) |
+----------------+----------+---------------------+
| minikube start | 56.8s    | 56.3s               |
| enable ingress | 28.5s    | 27.6s               |
+----------------+----------+---------------------+

Times for minikube start: 57.2s 57.1s 58.3s 55.5s 56.2s
Times for minikube (PR 14521) start: 56.3s 56.0s 56.4s 55.5s 57.1s

Times for minikube ingress: 28.6s 28.6s 25.2s 30.6s 29.6s
Times for minikube (PR 14521) ingress: 25.2s 28.7s 25.6s 29.6s 29.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14521) |
+----------------+----------+---------------------+
| minikube start | 28.0s    | 27.6s               |
| enable ingress | 34.8s    | 22.2s               |
+----------------+----------+---------------------+

Times for minikube start: 27.9s 28.2s 27.0s 27.7s 29.2s
Times for minikube (PR 14521) start: 26.9s 28.0s 28.1s 28.0s 27.1s

Times for minikube ingress: 22.0s 83.0s 22.5s 23.5s 23.0s
Times for minikube (PR 14521) ingress: 21.5s 20.5s 23.0s 23.0s 23.0s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14521) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 23.3s    | 30.2s ⚠️             |
| enable ingress    | 27.2s    | 27.3s               |
+-------------------+----------+---------------------+

Times for minikube start: 23.0s 23.0s 24.0s 23.3s 23.0s
Times for minikube (PR 14521) start: 23.5s 23.3s 34.8s 34.9s 34.7s

Times for minikube ingress: 27.4s 27.0s 27.4s 27.0s 27.0s
Times for minikube (PR 14521) ingress: 27.0s 27.4s 27.5s 27.5s 26.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 1.25 (chart)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 1.25 (chart)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 1.25 (chart)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 1.25 (chart)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 1.25 (chart)
Docker_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 3.97 (chart)
Docker_Linux_containerd TestOffline (gopogh) 21.25 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 21.25 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 23.12 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 23.12 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 23.12 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 23.12 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 23.12 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 23.12 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 23.12 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 23.12 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 23.12 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 23.12 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 23.12 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 23.12 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 23.12 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 23.12 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 23.12 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 23.12 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 23.12 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 23.12 (chart)
Docker_Linux_containerd TestMultiNode/serial/PingHostFrom2Pods (gopogh) 23.12 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 23.12 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 23.12 (chart)
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) 23.12 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

spowelljr
spowelljr approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making all these changes

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: siddhant-khisty, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 7e9b53b into kubernetes:master Aug 12, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2022
@siddhant-khisty siddhant-khisty deleted the update-addon-files branch August 13, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use fully qualified name in addon files
5 participants
@siddhant-khisty @k8s-ci-robot @minikube-bot @spowelljr @minikube-pr-bot