Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if addon has no associated Github username #15081

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Warn if addon has no associated Github username #15081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43d0753
warn if addon has no associated github username
klaases Oct 6, 2022
f6d3bf0
remove check for unknown maintainer
klaases Oct 6, 2022
f570363
update translations
klaases Oct 7, 2022
4cd9394
Update translations/fr.json
klaases Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/minikube/cmd/config/enable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,14 @@ var addonsEnableCmd = &cobra.Command{
You can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS`,
out.V{"addon": addon, "maintainer": maintainer})
} else {
out.Styled(style.Warning, `{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.`,
out.Styled(style.Warning, `{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.`,
out.V{"addon": addon})
if addonBundle.VerifiedMaintainer != "" {
out.Styled(style.Tip, `{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.`,
out.V{"addon": addon, "maintainer": maintainer, "verifiedMaintainer": addonBundle.VerifiedMaintainer})
} else {
out.Styled(style.Warning, `{{.addon}} does not currently have an associated maintainer.`,
out.V{"addon": addon})
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion translations/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,7 +1034,8 @@
"zsh completion.": "",
"{{ .name }}: Suggestion: {{ .suggestion}}": "{{ .name }}: Vorschlag: {{ .suggestion}}",
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "{{.Driver}} verwendet derzeit den {{.StorageDriver}} Storage Treiber, erwäge zu overlay2 zu wechseln für bessere Performance",
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} does not currently have an associated maintainer.": "",
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "{{.count}} Node{{if gt .count 1}}s{{end}} angehalten.",
Expand Down
3 changes: 2 additions & 1 deletion translations/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,8 @@
"{{ .name }}: Suggestion: {{ .suggestion}}": "{{ .name }}: Sugerencia: {{ .suggestion}}",
"{{ .name }}: {{ .rejection }}": "{{ .name }}: {{ .rejection }}",
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} does not currently have an associated maintainer.": "",
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "",
Expand Down
3 changes: 2 additions & 1 deletion translations/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,7 +1007,8 @@
"{{ .name }}: Suggestion: {{ .suggestion}}": "{{ .name }}: Suggestion: {{ .suggestion}}",
"{{ .name }}: {{ .rejection }}": "{{ .name }} : {{ .rejection }}",
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "{{.Driver}} utilise actuellement le pilote de stockage {{.StorageDriver}}, envisagez de passer à overlay2 pour de meilleures performances",
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "{{.addon}} est un module complémentaire tiers et non maintenu ou vérifié par les mainteneurs de minikube, activez-le à vos risques et périls.",
"{{.addon}} does not currently have an associated maintainer.": "",
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "{{.addon}} est un module complémentaire tiers et non maintenu ou vérifié par les mainteneurs de minikube, activez-le à vos risques et périls.",
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "{{.addon}} est un addon maintenu par {{.maintainer}}. Pour toute question, contactez minikube sur GitHub.\nVous pouvez consulter la liste des mainteneurs de minikube sur : https://github.com/kubernetes/minikube/blob/master/OWNERS",
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "{{.addon}} est maintenu par {{.maintainer}} pour tout problème, contactez {{.verifiedMaintainer}} sur GitHub.",
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "{{.count}} nœud{{if gt .count 1}}s{{end}} arrêté{{if gt .count 1}}s{{end}}.",
Expand Down
3 changes: 2 additions & 1 deletion translations/ja.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,8 @@
"zsh completion.": "zsh のコマンド補完です。",
"{{ .name }}: Suggestion: {{ .suggestion}}": "{{ .name }}: 提案: {{ .suggestion}}",
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "{{.Driver}} は現在 {{.StorageDriver}} ストレージドライバーを使用しています。性能向上のため overlay2 への切替を検討してください",
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} does not currently have an associated maintainer.": "",
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "{{.count}} 台のノードが停止しました。",
Expand Down
3 changes: 2 additions & 1 deletion translations/ko.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,7 +1037,8 @@
"zsh completion.": "",
"{{ .name }}: Suggestion: {{ .suggestion}}": "",
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} does not currently have an associated maintainer.": "",
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
"{{.count}} nodes stopped.": "{{.count}}개의 노드가 중지되었습니다.",
Expand Down
3 changes: 2 additions & 1 deletion translations/pl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,7 +1043,8 @@
"{{ .name }}: Suggestion: {{ .suggestion}}": "",
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
"{{.addonName}} was successfully enabled": "{{.addonName}} został aktywowany pomyślnie",
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} does not currently have an associated maintainer.": "",
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "",
Expand Down
3 changes: 2 additions & 1 deletion translations/ru.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,8 @@
"zsh completion.": "",
"{{ .name }}: Suggestion: {{ .suggestion}}": "",
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} does not currently have an associated maintainer.": "",
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "Остановлено узлов: {{.count}}.",
Expand Down
3 changes: 2 additions & 1 deletion translations/strings.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,8 @@
"zsh completion.": "",
"{{ .name }}: Suggestion: {{ .suggestion}}": "",
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} does not currently have an associated maintainer.": "",
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "",
Expand Down
3 changes: 2 additions & 1 deletion translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,8 @@
"zsh completion.": "",
"{{ .name }}: Suggestion: {{ .suggestion}}": "",
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} does not currently have an associated maintainer.": "",
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "",
Expand Down