Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert setting snapshotter to fuse-overlayfs #15272

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Revert setting snapshotter to fuse-overlayfs #15272

merged 3 commits into from
Nov 21, 2022

Conversation

spowelljr
Copy link
Member

Related #15191

We currently don't have containerd-fuse-overlayfs installed, so revert the changes in #15066 until it's installed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2022
@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2022
@spowelljr spowelljr force-pushed the fixFuseOverlayContainerd branch from 626a6d9 to a9963a7 Compare November 7, 2022 13:58
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2022
@spowelljr spowelljr removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 7, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15272) |
+----------------+----------+---------------------+
| minikube start | 56.1s    | 55.6s               |
| enable ingress | 28.4s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube start: 56.8s 54.3s 55.1s 54.8s 59.4s
Times for minikube (PR 15272) start: 53.6s 55.3s 57.7s 53.6s 57.9s

Times for minikube ingress: 28.2s 28.3s 28.8s 28.7s 28.2s
Times for minikube (PR 15272) ingress: 28.8s 29.8s 29.2s 28.2s 27.7s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 90

@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15272) |
+----------------+----------+---------------------+
| minikube start | 53.7s    | 53.6s               |
| enable ingress | 26.2s    | 26.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 15272) start: 53.1s 52.9s 53.0s 54.3s 54.9s
Times for minikube start: 52.8s 53.1s 53.9s 53.7s 54.9s

Times for minikube ingress: 27.6s 23.6s 27.6s 24.1s 28.3s
Times for minikube (PR 15272) ingress: 28.1s 24.6s 25.1s 25.1s 29.2s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 90

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestNoKubernetes/serial/StartNoArgs (gopogh) 0.00 (chart)
Hyperkit_macOS TestForceSystemdFlag (gopogh) 1.01 (chart)
Docker_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 9.89 (chart)
Docker_macOS TestStartStop/group/newest-cni/serial/Pause (gopogh) 21.57 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 36.49 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 37.70 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 37.70 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 38.21 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 38.71 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 41.80 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 42.28 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 42.74 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 42.74 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 44.31 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 50.00 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 50.81 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 51.20 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh) 51.59 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 73.64 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 76.87 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 93.44 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 99.05 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_Linux_containerd TestPreload (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/HairPin (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 0.00 (chart)
KVM_Linux TestGvisorAddon (gopogh) 0.00 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/specific-port (gopogh) 0.63 (chart)
Hyper-V_Windows TestNetworkPlugins/group/calico/Start (gopogh) 6.29 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 7.81 (chart)
Hyper-V_Windows TestErrorSpam/setup (gopogh) 9.79 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 21.38 (chart)
Docker_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 24.74 (chart)
Docker_Linux_containerd TestOffline (gopogh) 27.67 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 28.30 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 28.30 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 28.30 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 28.30 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 28.30 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 28.30 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 28.30 (chart)
Docker_Linux_containerd TestMultiNode/serial/PingHostFrom2Pods (gopogh) 28.30 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 28.30 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 28.30 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@AkihiroSuda
Copy link
Member

Any chance to get this merged? 🙏

@spowelljr
Copy link
Member Author

@AkihiroSuda Just waiting on one last change request on #15235 and once it's merged I'll rebase this PR and rebuild the kicbase image. That PR was forced to rebuild numerous times so I don't want to merge this first are make him have to go through another cycle.

@spowelljr spowelljr force-pushed the fixFuseOverlayContainerd branch from 6a3c5bf to 1b493e4 Compare November 18, 2022 16:00
@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15272) |
+----------------+----------+---------------------+
| minikube start | 55.0s    | 54.5s               |
| enable ingress | 26.9s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 15272) start: 54.2s 54.6s 55.2s 54.5s 54.1s
Times for minikube start: 54.9s 54.0s 55.6s 54.5s 56.1s

Times for minikube ingress: 27.6s 29.2s 25.2s 24.2s 28.2s
Times for minikube (PR 15272) ingress: 25.1s 28.2s 25.2s 27.7s 25.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15272) |
+----------------+----------+---------------------+
| minikube start | 25.3s    | 25.2s               |
| enable ingress | 21.0s    | 20.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 15272) start: 24.3s 25.5s 24.7s 26.0s 25.2s
Times for minikube start: 27.0s 25.3s 24.9s 24.5s 24.9s

Times for minikube ingress: 21.5s 20.9s 19.5s 22.4s 20.5s
Times for minikube (PR 15272) ingress: 19.0s 19.5s 21.9s 19.5s 20.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15272) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 25.7s               |
| enable ingress | 26.7s    | 26.0s               |
+----------------+----------+---------------------+

Times for minikube start: 21.6s 24.2s 22.9s 21.3s 21.5s
Times for minikube (PR 15272) start: 21.7s 21.9s 26.3s 24.6s 33.9s

Times for minikube ingress: 26.5s 26.5s 27.9s 26.0s 26.4s
Times for minikube (PR 15272) ingress: 26.4s 26.5s 25.0s 26.4s 25.9s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15272) |
+----------------+----------+---------------------+
| minikube start | 54.7s    | 54.0s               |
| enable ingress | 26.1s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube start: 55.8s 55.1s 52.9s 53.6s 56.2s
Times for minikube (PR 15272) start: 53.7s 55.1s 55.1s 53.9s 52.4s

Times for minikube ingress: 27.2s 27.7s 25.7s 25.1s 24.7s
Times for minikube (PR 15272) ingress: 26.1s 24.7s 29.2s 29.1s 28.6s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 90

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 5.48 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 39.63 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 43.15 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 48.97 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 50.68 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 76.80 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 80.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 81.95 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 99.15 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_Linux_containerd TestPreload (gopogh) 100.00 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/HairPin (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 100.00 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 100.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/kubenet/HairPin (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
KVM_Linux TestMultiNode/serial/ValidateNameConflict (gopogh) 100.00 (chart)
KVM_Linux TestNetworkPlugins/group/kubenet/HairPin (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/Setup (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/CacheCmd/cache/add_local (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 0.67 (chart)
Docker_macOS TestStartStop/group/newest-cni/serial/Pause (gopogh) 21.58 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 34.75 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 43.12 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 43.12 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 43.64 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 44.14 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 46.79 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 47.27 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 48.21 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 48.21 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 50.46 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 50.46 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 51.01 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 51.35 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh) 51.79 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 76.52 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 81.30 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 82.99 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 84.35 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 84.35 (chart)
Docker_Linux TestNetworkPlugins/group/calico/NetCatPod (gopogh) 86.67 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit a883397 into kubernetes:master Nov 21, 2022
@spowelljr spowelljr deleted the fixFuseOverlayContainerd branch November 21, 2022 17:46
@AkihiroSuda AkihiroSuda mentioned this pull request Dec 6, 2022
Closed
@criztovyl criztovyl mentioned this pull request Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@prezha prezha Awaiting requested review from prezha

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spowelljr @minikube-bot @k8s-ci-robot @minikube-pr-bot @AkihiroSuda @medyagh