Skip to content

Promote Qemu priority from "experimental" to "preferred" #15332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kloseliebej
Copy link

@kloseliebej kloseliebej commented Nov 9, 2022

Fixes #15316

Promoted to "preferred" because qemu is similar to kvm which is preferred, but open to other options.

Testing:

  1. Unit tests passed
  2. Tested locally using command "minikube start", though not seeing the options, probably because I don't have a M1 chip.

Screen Shot 2022-11-09 at 9 23 58 AM

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 9, 2022

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 9, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @kloseliebej!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @kloseliebej. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kloseliebej
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval by writing /assign @prezha in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@@ -48,7 +48,7 @@ func init() {
Config: configure,
Status: status,
Default: true,
Priority: registry.Experimental,
Priority: registry.Preferred,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should start out as registry.Default

@kloseliebej
Copy link
Author

Changed it to "default", though not sure how to fix this error
Screen Shot 2022-11-10 at 9 02 16 AM

@medyagh
Copy link
Member

medyagh commented Nov 11, 2022

@kloseliebej thanks for this contribution, the reason it is not working for you in the logs shows, because you have an existing cluster with a different driver, that you would need to delete first

1 similar comment
@medyagh
Copy link
Member

medyagh commented Nov 11, 2022

@kloseliebej thanks for this contribution, the reason it is not working for you in the logs shows, because you have an existing cluster with a different driver, that you would need to delete first

@medyagh
Copy link
Member

medyagh commented Nov 11, 2022

Changed it to "default", though not sure how to fix this error
Screen Shot 2022-11-10 at 9 02 16 AM

Seems like your first commit was pushed before signing the CLA so your would need to rebase and and force push your commit history :)

@spowelljr
Copy link
Member

Completed in #15556

@spowelljr spowelljr closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make sure minikube auto-selects Qemu Driver when Docker is not running and qemu is installed
6 participants