Skip to content

testing: added Setup subtest for ImageBuild #16492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2023

Conversation

spowelljr
Copy link
Member

If you have a test that fails in a parent, gopogh states that the test didn't fail, so add the setup into it's own subtest to prevent this from happening.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 11, 2023
@medyagh
Copy link
Member

medyagh commented May 12, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 12, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16492) |
+----------------+----------+---------------------+
| minikube start | 49.4s    | 51.6s               |
| enable ingress | 27.5s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 16492) start: 53.2s 51.0s 51.7s 50.2s 51.8s
Times for minikube start: 47.9s 48.0s 47.3s 51.9s 51.9s

Times for minikube ingress: 27.1s 27.6s 28.3s 27.1s 27.6s
Times for minikube (PR 16492) ingress: 27.1s 28.6s 27.0s 28.1s 27.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16492) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 23.8s               |
| enable ingress | 21.9s    | 21.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.3s 20.8s 22.8s 22.8s 20.8s
Times for minikube (PR 16492) ingress: 20.8s 20.8s 21.8s 20.8s 21.8s

Times for minikube start: 23.9s 22.6s 25.6s 21.7s 24.7s
Times for minikube (PR 16492) start: 25.8s 25.5s 21.8s 22.9s 22.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16492) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.9s               |
| enable ingress | 28.9s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 27.0s 20.3s 20.8s 19.8s 20.3s
Times for minikube (PR 16492) start: 23.4s 20.1s 20.9s 24.4s 20.7s

Times for minikube ingress: 31.3s 18.3s 31.3s 32.3s 31.3s
Times for minikube (PR 16492) ingress: 31.3s 31.3s 31.3s 31.4s 32.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
QEMU_macOS TestImageBuild/serial/Setup (gopogh) n/a
KVM_Linux TestMinikubeProfile (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/DeployApp (gopogh) 1.96 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh) 1.96 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/FirstStart (gopogh) 1.96 (chart)
Hyperkit_macOS TestErrorSpam/setup (gopogh) 3.27 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/StatusCmd (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh) 4.49 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/DNSResolutionByDig (gopogh) 4.49 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 642583e into kubernetes:master May 16, 2023
@spowelljr spowelljr deleted the addSetupSubtest branch May 25, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants