Skip to content

Add timeout to testDashboard, skip testTunnel if sudo password is required. #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 20, 2018
Merged

Add timeout to testDashboard, skip testTunnel if sudo password is required. #3314

merged 4 commits into from
Nov 20, 2018

Conversation

tstromberg
Copy link
Contributor

This may help to address issues we're seeing with panic timeouts on OSX, such as #3203

@tstromberg tstromberg requested a review from balopat November 8, 2018 00:44
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2018
@k8s-ci-robot k8s-ci-robot requested a review from dlorenc November 8, 2018 00:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 8, 2018
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@RA489
Copy link

RA489 commented Nov 12, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RA489, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@RA489: changing LGTM is restricted to assignees, and only kubernetes/minikube repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

dlorenc
dlorenc reviewed Nov 12, 2018
View reviewed changes
Copy link
Contributor

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

@balopat
Copy link
Contributor

balopat commented Nov 13, 2018

@minikube-bot OK to test

@tstromberg tstromberg merged commit dd2ef87 into kubernetes:master Nov 20, 2018
@tstromberg tstromberg deleted the dashboard_on_demand branch November 20, 2018 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc approved these changes

@balopat balopat Awaiting requested review from balopat

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tstromberg @RA489 @k8s-ci-robot @balopat @dlorenc