MEP: Background service to update host dns resolution for ingress resources #5511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Hi @woodcockjosh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
|
Can one of the admins verify this patch? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: woodcockjosh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ost DNS resolvers
woodcockjosh
force-pushed
the
add-ingress-host-os-resolver-service
branch
from
4f01b9f to
dd77f4c
Compare
|
/assign @tstromberg |
|
Partially resolves #5494 |
Codecov Report
@@ Coverage Diff @@
## master #5511 +/- ##
==========================================
+ Coverage 36.57% 36.63% +0.06%
==========================================
Files 102 102
Lines 7320 7346 +26
==========================================
+ Hits 2677 2691 +14
- Misses 4292 4298 +6
- Partials 351 357 +6
|
|
@minikube-bot OK to test |
tstromberg
reviewed
Oct 2, 2019
...osed/20191001-background-service-to-update-dns-resolvers-on-host-os-for-ingress-resources.md
Outdated
Show resolved
Hide resolved
| number to my memory for every service I need to access. If I don't have a good memory then this is really terrible | ||
| for me as I have to keep a reference sheet of where everything is running or I have to look it up with `kubectl` | ||
| * If the static ip address is somehow configured then I only have to create the DNS entries one time | ||
| * Use `minikube tunnel` and an ingress dns resolver like CoreDNS then add a resolver file for the internal host IP |
There was a problem hiding this comment.
It's worth noting for this proposal that "tunnel" does update the host resolver on macOS.
We've been thinking more and more about background services, as we've been hitting limits with what is possible without one. This is especially true when we start to think about the minikube UI project. Here's some things we would also like to do with a daemon (outside of the scope of this proposal)
- Resource alerts ("kubectl get node" is noticing bad things)
- Time synchronization for hyperkit
Perhaps we should think about having a minikubed with this as one of the first features?
There was a problem hiding this comment.
minikubed sounds cool. How would we install the daemon? Like what would the command be?
There was a problem hiding this comment.
@tstromberg FYI the mini program I implemented was designed so that it could be used as a basis for a daemon. Of course you may have very different ideas about how to implement and/or suggestions. Please have a look:
The general idea is that each task can specify the maximum frequently that it wants to run while still having a single thread to perform all tasks.
If we want the daemon to be listening on a port so that it could provide info and respond to events I believe this could be achieved as well in addition to having a looping process but any process that is listening on a port I would expect to run on a different thread than the looping process.
tstromberg
changed the title
Merged
Travis tests have failedHey @woodcockjosh, 1st Buildmake testTravisBuddy Request Identifier: 14857040-e6b1-11e9-9927-991e8c29daea |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
Error: running mkcmp: exit status 1 |
tstromberg
approved these changes
Nov 6, 2019
|
Closing until this proposal can be refreshed and looked at again. I suspect we may need to adjust the MEP workflow to allow for faster iteration and approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to create a background service that runs on the host OS and automatically updates resolver configurations based on host names in ingress resources and minikube ip addresses
If this is implemented it will enable a developer to access
redis1.myproject1.teston the right minikube instance regardless of what the minikube ip is and their only configuration is the ingress resource that is installed in the cluster.