Reportcard again

[afbjorklund]

Improve gofmt (!), golint and gocyclo.

Issues: 11
gofmt: 99%
	pkg/minikube/registry/global_test.go
		Line 1: warning: file is not gofmted with -s (gofmt)
go_vet: 100%
golint: 98%
	cmd/minikube/cmd/status.go
		Line 43: warning: exported var KubeconfigStatus should have comment or be unexported (golint)
	pkg/minikube/driver/driver.go
		Line 29: warning: exported const Mock should have comment (or a comment on this block) or be unexported (golint)
	pkg/minikube/driver/driver_linux.go
		Line 33: warning: exported function VBoxManagePath should have comment or be unexported (golint)
	pkg/minikube/registry/registry.go
		Line 32: warning: exported const Unknown should have comment (or a comment on this block) or be unexported (golint)
gocyclo: 98%
	cmd/minikube/cmd/start.go
		Line 272: warning: cyclomatic complexity 21 of function runStart() is high (> 15) (gocyclo)
		Line 982: warning: cyclomatic complexity 18 of function validateNetwork() is high (> 15) (gocyclo)
	test/integration/a_serial_test.go
		Line 38: warning: cyclomatic complexity 18 of function TestDownloadOnly() is high (> 15) (gocyclo)
	test/integration/fn_tunnel_cmd.go
		Line 40: warning: cyclomatic complexity 18 of function validateTunnelCmd() is high (> 15) (gocyclo)
	test/integration/gvisor_addon_test.go
		Line 29: warning: cyclomatic complexity 18 of function TestGvisorAddon() is high (> 15) (gocyclo)
	cmd/minikube/cmd/delete.go
		Line 177: warning: cyclomatic complexity 16 of function deleteProfile() is high (> 15) (gocyclo)
		Line 90: warning: cyclomatic complexity 16 of function runDelete() is high (> 15) (gocyclo)
	test/integration/fn_mount_cmd.go
		Line 46: warning: cyclomatic complexity 29 of function validateMountCmd() is high (> 15) (gocyclo)
ineffassign: 100%
license: 100%
misspell: 100%

The integration tests are tricky, they are by their nature sequential and require setup/takedown.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afbjorklund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-io]

Codecov Report

Merging #5679 into master will decrease coverage by 0.04%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##           master    #5679      +/-   ##
==========================================
- Coverage   36.58%   36.54%   -0.05%     
==========================================
  Files         110      110              
  Lines        8096     8114      +18     
==========================================
+ Hits         2962     2965       +3     
- Misses       4745     4760      +15     
  Partials      389      389

Impacted Files	Coverage Δ
pkg/minikube/driver/driver.go	95.74% <ø> (ø)	⬆️
pkg/minikube/driver/driver_linux.go	0% <ø> (ø)	⬆️
cmd/minikube/cmd/status.go	7.69% <ø> (ø)	⬆️
pkg/minikube/registry/registry.go	100% <ø> (ø)	⬆️
cmd/minikube/cmd/start.go	20% <0%> (-0.37%)	⬇️
cmd/minikube/cmd/delete.go	29.14% <30%> (+0.64%)	⬆️