Skip to content

Handle empty k8s version in existing profile #6292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

afbjorklund
Copy link
Collaborator

Fixes #6291

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@codecov-io
Copy link

Codecov Report

Merging #6292 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6292   +/-   ##
=======================================
  Coverage   38.28%   38.28%           
=======================================
  Files         124      124           
  Lines        8257     8257           
=======================================
  Hits         3161     3161           
  Misses       4686     4686           
  Partials      410      410
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 22.03% <100%> (ø) ⬆️

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 13, 2020
@minikube-bot
Copy link
Collaborator

All Times Minikube (PR 6292): [ 125.700559 111.029539 113.866473]
All Times minikube: [ 124.011131 124.005956 124.272921]

Average minikube: 124.096669
Average Minikube (PR 6292): 116.865523

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6292) |
+----------------------+-----------+--------------------+
| minikube v           |  0.460113 |           0.408210 |
| Creating kvm2        | 47.138752 |          46.240212 |
| Preparing Kubernetes | 50.490941 |          44.826703 |
| Pulling images       |  3.396616 |           2.636312 |
| Launching Kubernetes | 19.999320 |          19.993081 |
| Waiting for cluster  |  2.566196 |           2.718007 |
| Done                 |           |                    |
|                      |  0.045155 |           0.046172 |
+----------------------+-----------+--------------------+

@medyagh medyagh merged commit f5ce7d9 into kubernetes:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to parse "": Version string empty error
6 participants