Skip to content

Fix spacing in vm driver selection log #6449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2020

Conversation

priyawadhwa
Copy link

@priyawadhwa priyawadhwa commented Jan 31, 2020

Fixes #6439

Output is now:

$ minikube start
😄  minikube v1.7.0-beta.1 on Debian rodete
✨  Automatically selected the 'kvm2' driver (alternates: [none docker])

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2020
@priyawadhwa
Copy link
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@codecov-io
Copy link

Codecov Report

Merging #6449 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6449   +/-   ##
=======================================
  Coverage   37.68%   37.68%           
=======================================
  Files         128      128           
  Lines        8654     8654           
=======================================
  Hits         3261     3261           
  Misses       4970     4970           
  Partials      423      423
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 22.2% <0%> (ø) ⬆️

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 97.901808 97.216001 92.076595]
All Times Minikube (PR 6449): [ 93.754767 98.576178 97.055229]

Average minikube: 95.731468
Average Minikube (PR 6449): 96.462058

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6449) |
+----------------------+-----------+--------------------+
| minikube v           |  0.297351 |           0.289290 |
| Creating kvm2        | 20.391880 |          20.297181 |
| Preparing Kubernetes | 49.550459 |          49.359507 |
| Pulling images       |  3.451425 |           3.719190 |
| Launching Kubernetes | 19.257653 |          20.178011 |
| Waiting for cluster  |  2.731500 |           2.567745 |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Jan 31, 2020

Do you mind sharing the output in the pr description to compare ?

@priyawadhwa
Copy link
Author

@medyagh done

@priyawadhwa priyawadhwa merged commit 8babe97 into kubernetes:master Jan 31, 2020
@priyawadhwa priyawadhwa deleted the extraneous-space branch January 31, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extraneous space in "Automatically selected" line
7 participants