Skip to content

Improve perf test coverage #7880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2020

Conversation

n0npax
Copy link
Contributor

@n0npax n0npax commented Apr 24, 2020

Improve test coverage for perf package

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @n0npax. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: n0npax
To complete the pull request process, please assign afbjorklund
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@TravisBuddy
Copy link

Travis tests have failed

Hey @n0npax,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 386b6260-85c3-11ea-8961-b5c8adb971c9

@codecov-io
Copy link

Codecov Report

Merging #7880 into master will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7880      +/-   ##
==========================================
+ Coverage   35.57%   35.90%   +0.33%     
==========================================
  Files         148      148              
  Lines        9297     9305       +8     
==========================================
+ Hits         3307     3341      +34     
+ Misses       5593     5564      -29     
- Partials      397      400       +3     
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 15.42% <0.00%> (ø)
pkg/minikube/machine/cache_images.go 0.00% <0.00%> (ø)
cmd/minikube/cmd/start_flags.go 50.98% <0.00%> (+0.16%) ⬆️
pkg/minikube/bootstrapper/bsutil/kubeadm.go 83.56% <0.00%> (+0.46%) ⬆️
pkg/minikube/bootstrapper/bsutil/extraconfig.go 81.57% <0.00%> (+0.75%) ⬆️
pkg/minikube/perf/binary.go 78.94% <0.00%> (+73.68%) ⬆️

@RA489
Copy link

RA489 commented Apr 28, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@n0npax
Copy link
Contributor Author

n0npax commented Apr 28, 2020

/retest

Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution, this is great!

@priyawadhwa priyawadhwa merged commit 6f6ac3a into kubernetes:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants