Skip to content

add windows tests to github actions #8194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 18, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented May 18, 2020

parted out from this PR from scratch for a cleaner commit history:

This PR:

  • Adds gopogh-ified functional tests on windows for both docker and hyperv drivers

VM details:

  • For a list of the self-hosted action runners and their labels see: https://github.com/kubernetes/minikube/settings/actions
  • Created 6 Self-hosted Windows 10-enterprise VMs:
    2 windows-10-enterprise with 8 CPU cores (16 virtual cpus) - 32 GB Ram ( meant for hyperv test)
    4 windows-10-enterprise 4 CPU cores (8 virtual cpus) - 32 GB Ram (meant for docker desktop test)
      --  Installed the following on the VM:
      -- chocolatey
      -- gopogh (v0.1.23)
      -- enabled nested hyperV
      -- latest docker desktop (19.03.8) and modify default Ram and CPU on docker desktop

Special thanks
Special thanks to @lachie83 @marosset in sig-windows for providing the azure VMs, and helping with windows questions.

Footnote
nested virtualization on windows is very slow. on a real windows machine, this test should take 3-4 minutes, but it takes 10 minutes. we might need higher performant windows machines for faster CI

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 18, 2020
@marosset
Copy link

Awesome!

@medyagh medyagh merged commit ea57839 into kubernetes:master May 18, 2020
@medyagh medyagh deleted the windows_test_in_ghaction branch March 2, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants