add windows tests to github actions #8194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parted out from this PR from scratch for a cleaner commit history:
This PR:
VM details:
2 windows-10-enterprise with 8 CPU cores (16 virtual cpus) - 32 GB Ram ( meant for hyperv test)
4 windows-10-enterprise 4 CPU cores (8 virtual cpus) - 32 GB Ram (meant for docker desktop test)
Special thanks
Special thanks to @lachie83 @marosset in sig-windows for providing the azure VMs, and helping with windows questions.
Footnote
nested virtualization on windows is very slow. on a real windows machine, this test should take 3-4 minutes, but it takes 10 minutes. we might need higher performant windows machines for faster CI