Add support for Error type to JSON output #8796

priyawadhwa · 2020-07-21T21:15:31Z

adds support, unit tests, and new integration tests for Error type for JSON output

this is the last PR in adding support for JSON output

sample output with error:

$ minikube start --driver fail --output json
{"data":{"currentstep":"0","message":"minikube v1.12.1 on Darwin 10.14.6\n","name":"Initial Minikube Setup","totalsteps":"9"},"datacontenttype":"application/json","id":"4b69ea87-1b11-42cb-8190-dc414545cfd8","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}
{"data":{"exitcode":"69","message":"The driver 'fail' is not supported on darwin\n"},"datacontenttype":"application/json","id":"d7440fee-ddf6-4961-a5e6-2c20d502e2a4","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.error"}

#8655

priyawadhwa · 2020-07-21T21:15:39Z

/ok-to-test

k8s-ci-robot · 2020-07-21T21:15:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2020-07-21T21:42:24Z

kvm2 Driver
Times for minikube: [64.915150423 61.347816756 64.70160688200001]
Average time for minikube: 63.654858020333336

Times for Minikube (PR 8796): [64.486938388 63.79499268500001 62.590780738]
Average time for Minikube (PR 8796): 63.62423727033334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8796) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.061945 |           0.059180 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020100 |           0.022656 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003321 |           0.007776 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.340736 |          40.484973 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.673117 |          21.485264 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.437518 |           1.283232 |
| components...                  |           |                    |
| * Enabled addons:              |  0.037571 |           0.205221 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.076135 |           0.070931 |
| configured to use "minikube"   |           |                    |
|                                |  0.004414 |           0.005003 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.714162855 26.510648046 27.695143242999997]
Average time for minikube: 26.973318048

Times for Minikube (PR 8796): [27.996356354999996 25.811106002000002 26.329489071999998]
Average time for Minikube (PR 8796): 26.712317143000003

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8796) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.077294 |           0.077197 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.111891 |           0.103392 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.058444 |           0.058480 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.459284 |           8.605914 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 17.178822 |          16.883311 |
| on Docker 19.03.2 ...          |           |                    |
| * Verifying Kubernetes         |  1.017576 |           0.910048 |
| components...                  |           |                    |
| * Enabled addons:              |  0.002667 |           0.002868 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.061941 |           0.066185 |
| configured to use "minikube"   |           |                    |
|                                |  0.005399 |           0.004923 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-07-21T22:32:33Z

kvm2 Driver
Times for minikube: [65.19560134500001 63.386708451000004 64.648406516]
Average time for minikube: 64.41023877066667

Times for Minikube (PR 8796): [65.944673229 66.440838214 63.75835592400001]
Average time for Minikube (PR 8796): 65.38128912233333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8796) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.058791 |           0.066366 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.021769 |           0.024712 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003227 |           0.003373 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.075401 |          41.007214 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.357455 |          22.714768 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.522425 |           1.439164 |
| components...                  |           |                    |
| * Enabled addons:              |  0.285064 |           0.044733 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.082011 |           0.076992 |
| configured to use "minikube"   |           |                    |
|                                |  0.004096 |           0.003967 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.688830006999996 28.093189203 26.828647982000003]
Average time for minikube: 26.870222397333333

Times for Minikube (PR 8796): [27.043089654 26.375889321000002 26.587108768999997]
Average time for Minikube (PR 8796): 26.668695914666667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8796) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.076683 |           0.075635 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.102017 |           0.104091 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.058637 |           0.059174 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.395512 |           8.476831 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 17.211969 |          16.916592 |
| on Docker 19.03.2 ...          |           |                    |
| * Verifying Kubernetes         |  0.955521 |           0.900579 |
| components...                  |           |                    |
| * Enabled addons:              |  0.004275 |           0.061287 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.062338 |           0.070874 |
| configured to use "minikube"   |           |                    |
|                                |  0.003270 |           0.003632 |
+--------------------------------+-----------+--------------------+

medyagh

looks good just a linting nit

pkg/minikube/out/register/log.go

TravisBuddy · 2020-07-22T19:07:41Z

Travis tests have failed

Hey @priyawadhwa,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="03fd07b9a50e9c3816ceb0fc234eed52deb40307"" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading k8s.io/apimachinery v0.17.3
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/docker/go-units v0.4.0
go: downloading k8s.io/api v0.17.3
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading k8s.io/kubernetes v1.17.3
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/prometheus/common v0.9.1
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading github.com/docker/go-connections v0.4.0
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: downloading github.com/otiai10/copy v1.0.2
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/google/go-cmp v0.4.1
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/json-iterator/go v1.1.9
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/google/gofuzz v1.0.0
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading sigs.k8s.io/yaml v1.1.0
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/miekg/dns v1.1.27
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading k8s.io/kubelet v0.17.3
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading k8s.io/kube-proxy v0.17.3
go: downloading go.uber.org/multierr v1.1.0
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading go.uber.org/atomic v1.4.0
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
ok  	k8s.io/minikube/cmd/minikube/cmd	3.563s	coverage: 19.7% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.164s	coverage: 21.5% of statements
ok  	k8s.io/minikube/pkg/addons	0.078s	coverage: 53.3% of statements
ok  	k8s.io/minikube/pkg/drivers	0.010s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.013s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.015s	coverage: 0.0% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.023s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	1.129s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.102s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.025s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.003s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.086s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.018s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.146s	coverage: 70.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.054s	coverage: 36.6% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.022s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.023s	coverage: 34.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.008s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.032s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.032s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.006s	coverage: 50.0% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.035s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.361s	coverage: 37.7% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.016s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.056s	coverage: 58.0% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.010s	coverage: 76.5% of statements
2020/07/22 19:06:35 Running: [sh -c echo hi && sleep 3 && echo hey && sleep 1]...
--- FAIL: TestTimeCommandLogs (4.02s)
    logs_test.go:42: expected log "hi" to take more time than it actually did. got 2.99932652, expected > 3
FAIL
coverage: 33.8% of statements
FAIL	k8s.io/minikube/pkg/minikube/perf	4.138s
ok  	k8s.io/minikube/pkg/minikube/problem	0.013s	coverage: 92.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.010s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.009s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.092s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.012s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.028s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.032s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.034s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.652s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.436s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.005s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.003s	coverage: 0.0% of statements
FAIL
Makefile:274: recipe for target 'test' failed
make: *** [test] Error 32

TravisBuddy Request Identifier: 9bf74390-cc4e-11ea-acda-6fc69b852bf0

minikube-pr-bot · 2020-07-22T19:23:00Z

kvm2 Driver
Times for minikube: [62.731566479000016 63.895504681999995 57.941577156]
Average time for minikube: 61.52288277233333

Times for Minikube (PR 8796): [64.070211894 65.746263648 66.247124453]
Average time for Minikube (PR 8796): 65.35453333166667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8796) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.053638 |           0.059256 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.017275 |           0.017607 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.002950 |           0.002889 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.261497 |          41.347617 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 20.573304 |          21.962803 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.375849 |           1.626852 |
| components...                  |           |                    |
| * Enabled addons:              |  0.158993 |           0.259957 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.074875 |           0.073964 |
| configured to use "minikube"   |           |                    |
|                                |  0.004502 |           0.003590 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.221396802 26.621471178 25.710470266999998]
Average time for minikube: 26.517779415666666

Times for Minikube (PR 8796): [26.155598703 27.467513937 26.454692323999993]
Average time for Minikube (PR 8796): 26.692601654666664

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8796) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.066053 |           0.067085 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.098400 |           0.097175 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.056392 |           0.055894 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.517297 |           8.106065 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 16.804234 |          17.385901 |
| on Docker 19.03.2 ...          |           |                    |
| * Verifying Kubernetes         |  0.822426 |           0.848990 |
| components...                  |           |                    |
| * Enabled addons:              |  0.088911 |           0.062665 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.059980 |           0.064570 |
| configured to use "minikube"   |           |                    |
|                                |  0.004087 |           0.004256 |
+--------------------------------+-----------+--------------------+

Priya Wadhwa added 4 commits July 21, 2020 15:43

implement errors in JSON

482b9be

Add unit test for problem.DisplayJSON()

b4b9013

add json unit tests

6ca7222

Add integration test for error

5c09250

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 21, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 21, 2020

k8s-ci-robot requested a review from prasadkatti July 21, 2020 21:15

k8s-ci-robot requested a review from RA489 July 21, 2020 21:15

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2020

Priya Wadhwa added 2 commits July 21, 2020 18:20

Rebased on master; fixed json_output integration test

8bc875d

fix unit test

6a33c03

priyawadhwa force-pushed the error branch from 5c1d06b to 6a33c03 Compare July 21, 2020 22:23

priyawadhwa changed the title ~~wip: Add support for Error type to JSON output~~ Add support for Error type to JSON output Jul 22, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2020

priyawadhwa requested a review from medyagh July 22, 2020 15:59

medyagh approved these changes Jul 22, 2020

View reviewed changes

pkg/minikube/out/register/log.go Show resolved Hide resolved

add log

3f18ecb

priyawadhwa merged commit 25566c9 into kubernetes:master Jul 22, 2020

priyawadhwa deleted the error branch July 22, 2020 22:43

fmotrifork mentioned this pull request Aug 6, 2020

minikube 1.12.2 fishworks/fish-food#883

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Error type to JSON output #8796

Add support for Error type to JSON output #8796

priyawadhwa commented Jul 21, 2020 •

edited

Loading

priyawadhwa commented Jul 21, 2020

k8s-ci-robot commented Jul 21, 2020

minikube-pr-bot commented Jul 21, 2020

minikube-pr-bot commented Jul 21, 2020

medyagh left a comment

TravisBuddy commented Jul 22, 2020

minikube-pr-bot commented Jul 22, 2020

Add support for Error type to JSON output #8796

Add support for Error type to JSON output #8796

Conversation

priyawadhwa commented Jul 21, 2020 • edited Loading

priyawadhwa commented Jul 21, 2020

k8s-ci-robot commented Jul 21, 2020

minikube-pr-bot commented Jul 21, 2020

minikube-pr-bot commented Jul 21, 2020

medyagh left a comment

Choose a reason for hiding this comment

TravisBuddy commented Jul 22, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 9bf74390-cc4e-11ea-acda-6fc69b852bf0

minikube-pr-bot commented Jul 22, 2020

priyawadhwa commented Jul 21, 2020 •

edited

Loading