Bump nginx-ingress-controller #8839

staticdev · 2020-07-25T10:46:52Z

Bump ingress-nginx-controller to 0.34.1
Stop using quay.io repository which was deprecated
Add ingress enabling on performance tests

k8s-ci-robot · 2020-07-25T10:46:59Z

Welcome @staticdev!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-07-25T10:46:59Z

Hi @staticdev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-07-25T10:47:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: staticdev
To complete the pull request process, please assign afbjorklund
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-bot · 2020-07-25T10:48:03Z

Can one of the admins verify this patch?

staticdev · 2020-07-25T10:50:27Z

/assign @afbjorklund

staticdev · 2020-07-28T11:25:52Z

@tstromberg could you please check this PR?

sharifelgamal · 2020-07-29T18:46:24Z

/ok-to-test

minikube-pr-bot · 2020-07-29T19:06:46Z

kvm2 Driver
Times for minikube: [63.14301949400001 62.940931770999995 63.28553989499999]
Average time for minikube: 63.12316372

Times for Minikube (PR 8839): [64.949356375 64.03770624799999 62.95848740500001]
Average time for Minikube (PR 8839): 63.98185000933333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8839) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.059068 |           0.061762 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020300 |           0.019045 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003114 |           0.003047 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.819141 |          40.533262 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.005621 |          21.451988 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.459189 |           1.268670 |
| components...                  |           |                    |
| * Enabled addons:              |  0.680381 |           0.571249 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.071867 |           0.068972 |
| configured to use "minikube"   |           |                    |
|                                |  0.004483 |           0.003855 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.281105743999994 26.460627383000002 25.649866997000004]
Average time for minikube: 26.13053337466667

Times for Minikube (PR 8839): [27.409480799 27.077220233000002 26.245359197000003]
Average time for Minikube (PR 8839): 26.910686743

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8839) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.074496 |           0.073546 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.101678 |           0.100724 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.055065 |           0.056702 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.120668 |           8.080379 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 16.863780 |          17.642986 |
| on Docker 19.03.2 ...          |           |                    |
| * Verifying Kubernetes         |  0.829774 |           0.869058 |
| components...                  |           |                    |
| * Enabled addons:              |  0.013167 |           0.007366 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.068549 |           0.076321 |
| configured to use "minikube"   |           |                    |
|                                |  0.003356 |           0.003605 |
+--------------------------------+-----------+--------------------+

staticdev · 2020-07-29T19:15:37Z

@sharifelgamal It would be very nice if we could add to the tests ru by @minikube-pr-bot a new test Enabled addons: Ingress. This is also the main reason for this PR. I am not sure if/how I add this test to the PR.

TravisBuddy · 2020-08-12T11:16:19Z

Travis tests have failed

Hey @staticdev,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.2 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.2 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="23f0a19a88aa6b7c19b180631d53035e7048784d" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v2" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.29.0'
golangci/golangci-lint info found version: 1.29.0 for v1.29.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
pkg/minikube/perf/start.go:94:61: `timeEnableIngress` - `driver` is unused (unparam)
func timeEnableIngress(ctx context.Context, binary *Binary, driver string) (*result, error) {
                                                            ^
Makefile:389: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= go mod ================================================================
ok
= boilerplate ===========================================================
ok
Makefile:273: recipe for target 'test' failed
make: *** [test] Error 4

2nd Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.2 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.2 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="23f0a19a88aa6b7c19b180631d53035e7048784d" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v2" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200810185219-7d42fed1b770
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading k8s.io/api v0.17.3
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading k8s.io/apimachinery v0.17.3
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading k8s.io/kubernetes v1.17.3
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/otiai10/copy v1.0.2
go: downloading go.uber.org/atomic v1.4.0
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/miekg/dns v1.1.27
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading k8s.io/klog v1.0.0
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/json-iterator/go v1.1.9
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading sigs.k8s.io/yaml v1.1.0
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/google/gofuzz v1.0.0
go: downloading github.com/prometheus/common v0.9.1
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading k8s.io/kubelet v0.17.3
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading go.uber.org/multierr v1.1.0
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading k8s.io/kube-proxy v0.17.3
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading github.com/google/go-cmp v0.4.1
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
ok  	k8s.io/minikube/cmd/minikube/cmd	6.046s	coverage: 18.7% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.050s	coverage: 21.5% of statements
ok  	k8s.io/minikube/pkg/addons	0.085s	coverage: 52.5% of statements
ok  	k8s.io/minikube/pkg/drivers	0.022s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.003s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.013s	coverage: 3.5% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.023s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.520s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.125s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.020s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.003s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.071s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.025s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.169s	coverage: 70.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.043s	coverage: 36.7% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.063s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.031s	coverage: 33.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.009s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.024s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.034s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.004s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.042s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.311s	coverage: 39.5% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	0.062s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.023s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.087s	coverage: 59.3% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.012s	coverage: 54.5% of statements
2020/08/12 11:15:08 Running: [sh -c echo hi && sleep 3 && echo hey && sleep 1]...
--- FAIL: TestTimeCommandLogs (4.01s)
    logs_test.go:42: expected log "hi" to take more time than it actually did. got 2.999717487, expected > 3
FAIL
coverage: 31.5% of statements
FAIL	k8s.io/minikube/pkg/minikube/perf	4.254s
ok  	k8s.io/minikube/pkg/minikube/problem	0.012s	coverage: 92.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.010s	coverage: 68.7% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.010s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.102s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.008s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.045s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.025s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.005s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.674s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.474s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.005s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.004s	coverage: 0.0% of statements
FAIL
Makefile:273: recipe for target 'test' failed
make: *** [test] Error 32

TravisBuddy Request Identifier: 3d7c30b0-dc8d-11ea-b6e2-493429cddfc3

minikube-pr-bot · 2020-08-12T11:20:08Z

kvm2 Driver
Times for minikube: [61.049730293 62.740285197999995 61.95707093300001]
Average time for minikube: 61.91569547466667

Times for Minikube (PR 8839): [63.442107514 54.63129148499999 64.234933391]
Average time for Minikube (PR 8839): 60.769444130000004

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8839) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.056870 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018120 |           0.016948 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003101 |           0.002951 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.091123 |          38.438562 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 20.294939 |          20.744479 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.333686 |           1.385219 |
| components...                  |           |                    |
| * Enabled addons:              |  0.027062 |           0.059066 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.082255 |           0.065078 |
| configured to use "minikube"   |           |                    |
|                                |  0.008541 |           0.004272 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.490576106000002 27.399224901999997 26.622849052999996]
Average time for minikube: 27.504216687

Times for Minikube (PR 8839): [26.504543811999998 26.143395087000002 26.48548803]
Average time for Minikube (PR 8839): 26.37780897633333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8839) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.066704 |                    |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.100311 |           0.096370 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.055499 |           0.055370 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.549122 |           8.371123 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 17.739792 |                    |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  0.877930 |           0.802347 |
| components...                  |           |                    |
| * Enabled addons:              |  0.044745 |           0.144248 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.062706 |           0.059741 |
| configured to use "minikube"   |           |                    |
|                                |  0.007408 |           0.003607 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-08-12T12:00:06Z

kvm2 Driver
Times for minikube: [82.835602733 61.201476481 62.861598779]
Average time for minikube: 68.96622599766667

Times for Minikube (PR 8839): [66.512347959 60.250573675000005 60.827208586000005]
Average time for Minikube (PR 8839): 62.53004340666667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8839) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.053158 |           0.052840 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018032 |           0.017171 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003036 |           0.003100 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.915443 |          39.197310 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 26.327205 |          21.499298 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.419686 |           1.419663 |
| components...                  |           |                    |
| * Enabled addons:              |  0.148591 |           0.254945 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.074113 |           0.077903 |
| configured to use "minikube"   |           |                    |
|                                |  0.006962 |           0.007813 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.091822533 26.707998399 27.304596112000002]
Average time for minikube: 27.034805681333335

Times for Minikube (PR 8839): [26.932033285 27.099501460000003 26.453917167999997]
Average time for Minikube (PR 8839): 26.828483970999997

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8839) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.063482 |           0.063948 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.097213 |           0.095823 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.055197 |           0.061739 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.449558 |           8.443948 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 17.240371 |          17.237291 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  0.889679 |           0.825558 |
| components...                  |           |                    |
| * Enabled addons:              |  0.170841 |           0.029215 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.059637 |           0.063127 |
| configured to use "minikube"   |           |                    |
|                                |  0.008828 |           0.007836 |
+--------------------------------+-----------+--------------------+

staticdev · 2020-08-12T12:21:34Z

@priyawadhwa I added a method and a call to minikube addons enable ingress after minikube start and it seems to be working on @minikube-pr-bot. Though, I couldn't see that on the Details. Do you know what I need to change to see?

Bump nginx-ingress-controller

68bc935

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 25, 2020

k8s-ci-robot requested review from blueelvis and prasadkatti July 25, 2020 10:47

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2020

k8s-ci-robot assigned afbjorklund Jul 25, 2020

medyagh approved these changes Jul 27, 2020

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2020

Add timing enable ingress

969bc9f

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2020

Fix go lint

4c5109b

tstromberg approved these changes Sep 1, 2020

View reviewed changes

tstromberg merged commit fae2358 into kubernetes:master Sep 1, 2020

jmkozko mentioned this pull request Oct 5, 2021

verifying ingress addon pods : timed out waiting for the condition: timed out waiting for the condition #8756

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump nginx-ingress-controller #8839

Bump nginx-ingress-controller #8839

Uh oh!

staticdev commented Jul 25, 2020 •

edited

Loading

Uh oh!

k8s-ci-robot commented Jul 25, 2020

Uh oh!

k8s-ci-robot commented Jul 25, 2020

Uh oh!

k8s-ci-robot commented Jul 25, 2020

Uh oh!

minikube-bot commented Jul 25, 2020

Uh oh!

staticdev commented Jul 25, 2020

Uh oh!

staticdev commented Jul 28, 2020

Uh oh!

sharifelgamal commented Jul 29, 2020

Uh oh!

minikube-pr-bot commented Jul 29, 2020

Uh oh!

staticdev commented Jul 29, 2020 •

edited

Loading

Uh oh!

TravisBuddy commented Aug 12, 2020

Uh oh!

minikube-pr-bot commented Aug 12, 2020

Uh oh!

minikube-pr-bot commented Aug 12, 2020

Uh oh!

staticdev commented Aug 12, 2020

Uh oh!

Uh oh!

Bump nginx-ingress-controller #8839

Bump nginx-ingress-controller #8839

Uh oh!

Conversation

staticdev commented Jul 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jul 25, 2020

Uh oh!

k8s-ci-robot commented Jul 25, 2020

Uh oh!

k8s-ci-robot commented Jul 25, 2020

Uh oh!

minikube-bot commented Jul 25, 2020

Uh oh!

staticdev commented Jul 25, 2020

Uh oh!

staticdev commented Jul 28, 2020

Uh oh!

sharifelgamal commented Jul 29, 2020

Uh oh!

minikube-pr-bot commented Jul 29, 2020

Uh oh!

staticdev commented Jul 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TravisBuddy commented Aug 12, 2020

Travis tests have failed

1st Build

2nd Build

TravisBuddy Request Identifier: 3d7c30b0-dc8d-11ea-b6e2-493429cddfc3

Uh oh!

minikube-pr-bot commented Aug 12, 2020

Uh oh!

minikube-pr-bot commented Aug 12, 2020

Uh oh!

staticdev commented Aug 12, 2020

Uh oh!

Uh oh!

staticdev commented Jul 25, 2020 •

edited

Loading

staticdev commented Jul 29, 2020 •

edited

Loading