start: fixed the type value for latest minikube version availability message

[vinu2003]

This PR addresses code changes that fix the value for type from "type":"io.k8s.sigs.minikube.error" to "type":"io.k8s.sigs.minikube.step" for the latest minikube version availability message.

Fixes #9108

{"data":{"currentstep":"6","message":"minikube 1.12.3 is available! Download it: https://github.com/kubernetes/minikube/releases/tag/v1.12.3\n","name":"Creating Container","totalsteps":"12"},"datacontenttype":"application/json","id":"9afa18a5-bb67-46f9-abd6-3deb86fc65a0","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}
{"data":{"currentstep":"6","message":"To disable this notice, run: 'minikube config set WantUpdateNotification false'\n\n","name":"Creating Container","totalsteps":"12"},"datacontenttype":"application/json","id":"41623db0-83f5-4a58-9d36-c3544760f49f","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}

[k8s-ci-robot]

Hi @vinu2003. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vinu2003
To complete the pull request process, please assign afbjorklund
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TravisBuddy]

Travis tests have failed

Hey @vinu2003,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.3 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.2 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="55dabf56230d2cc06cf22ad693976ccaa1f2ca39" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v2" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200810185219-7d42fed1b770
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading k8s.io/api v0.17.3
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/docker/go-units v0.4.0
go: downloading k8s.io/apimachinery v0.17.3
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading k8s.io/kubernetes v1.18.5
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading k8s.io/kubectl v0.17.3
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/google/gofuzz v1.1.0
go: downloading k8s.io/utils v0.0.0-20200324210504-a9aa75ae1b89
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/otiai10/copy v1.0.2
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/miekg/dns v1.1.27
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/spf13/cast v1.3.1
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/google/go-cmp v0.4.1
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading google.golang.org/api v0.25.0
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/prometheus/common v0.9.1
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading go.opencensus.io v0.22.3
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/json-iterator/go v1.1.9
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading k8s.io/component-base v0.17.3
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading k8s.io/kube-openapi v0.0.0-20200410145947-61e04a5be9a6
go: downloading sigs.k8s.io/yaml v1.2.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading go.uber.org/atomic v1.4.0
go: downloading go.uber.org/multierr v1.1.0
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
ok  	k8s.io/minikube/cmd/minikube/cmd	4.406s	coverage: 18.6% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.045s	coverage: 21.5% of statements
ok  	k8s.io/minikube/pkg/addons	0.085s	coverage: 52.5% of statements
ok  	k8s.io/minikube/pkg/drivers	0.007s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.005s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.013s	coverage: 3.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.028s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	1.137s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.120s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.021s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.004s	coverage: 83.1% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.065s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.025s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.150s	coverage: 70.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.053s	coverage: 36.7% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.036s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.021s	coverage: 33.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.017s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.032s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.035s	coverage: 80.7% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.018s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.037s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.097s	coverage: 36.8% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	0.052s	coverage: 10.5% of statements
E0828 08:09:45.965048   13666 notify.go:66] write time failed: Error writing current update time to file: : writefile failed for /etc/passwd: open /etc/passwd: permission denied
--- FAIL: TestMaybePrintUpdateText (0.02s)
    --- FAIL: TestMaybePrintUpdateText/latest_version_greater (0.01s)
        notify_test.go:232: Expected MaybePrintUpdateText to output text as the current version is v1.12.3 and version 100.0.0-dev was served from URL but output was []
FAIL
coverage: 92.9% of statements
FAIL	k8s.io/minikube/pkg/minikube/notify	0.040s
ok  	k8s.io/minikube/pkg/minikube/out	0.054s	coverage: 59.3% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.012s	coverage: 54.5% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.193s	coverage: 33.8% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.012s	coverage: 92.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.010s	coverage: 68.7% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.010s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.069s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.003s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.061s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.039s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.007s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.851s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	1.789s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.006s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.020s	coverage: 0.0% of statements
FAIL
Makefile:292: recipe for target 'test' failed
make: *** [test] Error 32

TravisBuddy Request Identifier: f446f260-e905-11ea-ae3c-2d16223a9f65

[minikube-bot]

Can one of the admins verify this patch?

[vinu2003]

need to fix the unit tests

[tstromberg]

This seems reasonable, now that we only call this from start.go. Thanks!