Skip to content

[go] Build go1.16.4 and go1.15.12 images #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 7, 2021
Merged

[go] Build go1.16.4 and go1.15.12 images #2059

merged 5 commits into from
May 7, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented May 7, 2021 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency release-eng/security

What this PR does / why we need it:

Tracking issue: #2060

ref: #2005 (comment)
(FYI @tao12345666333)

  • hack: Allow verify-dependencies to succeed when GOBIN is missing
  • [go] go1.16.4 and go1.15.12 updates
  • kube-cross: Build v1.16.4-1 and v1.15.12-1 images
  • go-runner: Build v2.3.1-go1.16.4-buster.0 and v2.3.1-go1.15.12-buster.0
  • releng-ci: Build v0.5.2 image using go1.16.4

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- hack: Allow verify-dependencies to succeed when GOBIN is missing
- [go] go1.16.4 and go1.15.12 updates
- kube-cross: Build v1.16.4-1 and v1.15.12-1 images
- go-runner: Build v2.3.1-go1.16.4-buster.0 and v2.3.1-go1.15.12-buster.0
- releng-ci: Build v0.5.2 image using go1.16.4

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/release-eng/security Issues or PRs related to release engineering security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from cpanato and hasheddan May 7, 2021 11:48
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021
@justaugustus justaugustus mentioned this pull request May 7, 2021
Closed
27 tasks
cpanato
cpanato approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@justaugustus
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 7, 2021
@justaugustus justaugustus changed the title Go116 [go] Build go1.16.4 and go1.15.12 images May 7, 2021
@justaugustus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@justaugustus
Copy link
Member Author

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/release/2059/pull-release-image-go-runner/1390634493068447744

The go1.16.4 go-runner builds passed, but the go1.15.12 variants failed with a SIGSEGV on s390x.

If that happens again, but everything else is passing, I'm overriding the test to push ahead.
@cpanato -- in that case that happens, I'll leave it to you to debug the 1.15.12 errors and bump a new image tag.

@cpanato
Copy link
Member

cpanato commented May 7, 2021

/test pull-release-integration-test

@justaugustus
Copy link
Member Author

justaugustus commented May 7, 2021 •
edited
Loading

/test pull-release-integration-test

@kubernetes/release-engineering -- just a note. When this failure happens, it's usually because of an API rate limit from GitHub:

Expected nil, but got: get latest GitHub tags: unable to retrieve GitHub tags: GET https://api.github.com/repos/kubernetes/kubernetes/tags?page=13&per_page=50: 403 API rate limit of 60 still exceeded until 2021-05-07 12:50:40 +0000 UTC, not making remote request. [rate reset in 29m56s]

ref: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/release/2059/pull-release-integration-test/1390641854835331072

I'd really, really love if this repo's CI didn't get blocked on this GH rate limit.
Who wants to work on that?

/skip pull-release-integration-test

@justaugustus
Copy link
Member Author

justaugustus commented May 7, 2021 •
edited
Loading

/override pull-release-integration-test
ref: #2059 (comment)

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Overrode contexts on behalf of justaugustus: pull-release-integration-test

In response to this:

/override pull-release-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member

cpanato commented May 7, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@justaugustus justaugustus added this to the v1.22 milestone May 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit ee7bae3 into kubernetes:master May 7, 2021
@cpanato
Copy link
Member

cpanato commented May 7, 2021

got a quota issue in the post go-runner job

ERROR: (gcloud.builds.submit) RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Build and Operation Get requests' and limit 'Build and Operation Get requests per minute' of service 'cloudbuild.googleapis.com' for consumer 'project_number:180382678033'.

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-release-push-image-go-runner/1390654421943193600

will wait a bit and retrigger that

cc @justaugustus

@cpanato
Copy link
Member

cpanato commented May 7, 2021

same for some jobs in kubecross
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-release-push-image-kube-cross/1390654421968359424

@cpanato
Copy link
Member

cpanato commented May 7, 2021

both jobs restarted

@tao12345666333 tao12345666333 mentioned this pull request May 7, 2021
Merged
tao12345666333
tao12345666333 reviewed May 7, 2021
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 left review comments

@cpanato cpanato cpanato approved these changes

@hasheddan hasheddan Awaiting requested review from hasheddan

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng/security Issues or PRs related to release engineering security area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@justaugustus @k8s-ci-robot @cpanato @tao12345666333