Skip to content

Bootstrap Release 1.21 directory #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2021
Merged

Bootstrap Release 1.21 directory #1405

merged 3 commits into from
Jan 8, 2021

Conversation

palnabarun
Copy link
Member

What type of PR is this:

/kind documentation

What this PR does / why we need it:

This PR bootstraps the release directory for Kubernetes 1.21

Follow up:

  • Update the TBCs with the actual dates

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

/area release-team
/sig release
/assign @justaugustus @saschagrunert @jeremyrickard @hasheddan @alejandrox1
/cc @kikisdeliveryservice @savitharaghunathan @bai
/cc @annajung @divya-mohan0209 @erismaster @reylejano @thejoycekung @wilsonehusin

@palnabarun
release-1.21: add OWNERS
e831ff9 
Signed-off-by: Nabarun Pal <[email protected]>
@k8s-ci-robot k8s-ci-robot added the area/release-team Issues or PRs related to the release-team subproject label Jan 7, 2021
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 7, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2021
@palnabarun
Copy link
Member Author

/milestone 1.21

@k8s-ci-robot
Copy link
Contributor

@palnabarun: The provided milestone is not valid for this repository. Milestones in this repository: [next, v1.16, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun
Copy link
Member Author

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 7, 2021
@palnabarun palnabarun force-pushed the release-1.21-bootstrap branch from 8b82023 to bed404d Compare January 7, 2021 19:05
reylejano
reylejano suggested changes Jan 7, 2021
View reviewed changes
Copy link
Member

@reylejano reylejano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In release_team.md:

  • updated my Slack handle
  • updated the minor release version to 1.21

@palnabarun palnabarun force-pushed the release-1.21-bootstrap branch from bed404d to 2b6fd15 Compare January 7, 2021 19:23
@bai
Copy link
Contributor

bai commented Jan 8, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2021
savitharaghunathan
savitharaghunathan approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@reylejano
Copy link
Member

/lgtm

@wilsonehusin
Copy link
Contributor

/lgtm

(let's get this team!) 🎉

@palnabarun palnabarun mentioned this pull request Jan 8, 2021
Closed
21 tasks
justaugustus
justaugustus requested changes Jan 8, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microscopic nit: Can we use hyphens for the filenames moving forward?

So s/release_team.md/release-team.md.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bai, palnabarun, reylejano, savitharaghunathan, wilsonehusin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0372b78 into kubernetes:master Jan 8, 2021
@justaugustus
Copy link
Member

(that was weird; bot interpreted my "Request Changes" as an "Approve")

@palnabarun
Copy link
Member Author

That was really weird. I am opening a follow on PR for the same.

@justaugustus
Copy link
Member

Thanks!

@savitharaghunathan
Copy link
Member

(that was weird; bot interpreted my "Request Changes" as an "Approve")

Could be it be because the OWNERS PR got merged. and all our lgtm's has magical implicit approval powers? So when Stephen commented on the review, the bot did something to add approval based on the previous lgtm?

@palnabarun palnabarun mentioned this pull request Jan 8, 2021
Merged
@palnabarun
Copy link
Member Author

@justaugustus -- follow-up #1408

@savitharaghunathan -- highly likely. I was also guessing on similar lines.

@palnabarun palnabarun deleted the release-1.21-bootstrap branch January 8, 2021 19:14
@justaugustus
Copy link
Member

Could be it be because the OWNERS PR got merged. and all our lgtm's has magical implicit approval powers? So when Stephen commented on the review, the bot did something to add approval based on the previous lgtm?

Yep, I missed #1407, but that explains it.
Nabarun got implicit approve on the releases/ directory once that happened. Thanks y'all!

@jeremyrickard
Copy link
Contributor

LOL this happened to me in 1.20 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan left review comments

@justaugustus justaugustus justaugustus requested changes

@reylejano reylejano reylejano requested changes

@savitharaghunathan savitharaghunathan savitharaghunathan approved these changes

@annajung annajung Awaiting requested review from annajung

@bai bai Awaiting requested review from bai

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@erismaster erismaster Awaiting requested review from erismaster

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@thejoycekung thejoycekung Awaiting requested review from thejoycekung

@wilsonehusin wilsonehusin Awaiting requested review from wilsonehusin

Assignees

@bai bai

@justaugustus justaugustus

@saschagrunert saschagrunert

@savitharaghunathan savitharaghunathan

@alejandrox1 alejandrox1

@wilsonehusin wilsonehusin

@hasheddan hasheddan

@jeremyrickard jeremyrickard

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.