Skip to content

Added 1.31 code freeze exception requests to the exceptions.yaml file #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sreeram-venkitesh
Copy link
Member

What type of PR is this:

/kind documentation

What this PR does / why we need it:

For documenting the code freeze exception requests received in the v1.31 release cycle, after code freeze was in place.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

CC: @neoaggelos

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-team Issues or PRs related to the release-team subproject needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 10, 2024
@sreeram-venkitesh
Copy link
Member Author

@neoaggelos Can we get this merged?

@neoaggelos
Copy link
Contributor

/lgtm /approve

@sreeram-venkitesh
Copy link
Member Author

@neoaggelos I think the /lgtm and /approve needs to be in separate lines to take effect? Not sure why it didn't work.

@neoaggelos
Copy link
Contributor

/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neoaggelos, sreeram-venkitesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 542c5f1 into kubernetes:master Aug 27, 2024
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants