-
Notifications
You must be signed in to change notification settings - Fork 65
Added README #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added README #24
Conversation
Signed-off-by: Ayushman Mishra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits. Otherwise lgtm.
Hey @savitharaghunathan can you please review my PR and give me some helpful suggestions if required. |
README.md
Outdated
- Slack: [#sig-security](https://kubernetes.slack.com/messages/sig-security) | ||
- [Mailing list](https://groups.google.com/forum/#!forum/kubernetes-sig-security) | ||
- [Open Community Issues/PRs](https://github.com/kubernetes/community/labels/sig%2Fsecurity) | ||
- [Sig-Security Issues](https://github.com/kubernetes/sig-security/issues) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [Sig-Security Issues](https://github.com/kubernetes/sig-security/issues) | |
- [SIG Security Issues](https://github.com/kubernetes/sig-security/issues) |
Hey all , I was just thinking "it'd be nice if we had a README" then realise this was here :) what do we think needs done to get this one merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried all the URLs and everything seems correct!
Just a nit to remove the template comments in the markdown that are no longer needed but do not appear anyway so...
Sorry for not reviewing sooner and thanks so much for taking the time to write the SIG readme!
README.md
Outdated
<!--- | ||
This is an autogenerated file! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!--- | |
This is an autogenerated file! |
README.md
Outdated
Please do not edit this file directly, but instead make changes to the | ||
sigs.yaml file in the project root. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not edit this file directly, but instead make changes to the | |
sigs.yaml file in the project root. |
README.md
Outdated
To understand how this file is generated, see https://git.k8s.io/community/generator/README.md | ||
---> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To understand how this file is generated, see https://git.k8s.io/community/generator/README.md | |
---> |
README.md
Outdated
<!-- BEGIN CUSTOM CONTENT --> | ||
|
||
<!-- END CUSTOM CONTENT --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- BEGIN CUSTOM CONTENT --> | |
<!-- END CUSTOM CONTENT --> |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor suggestion. Otherwise, lgtm
Thanks for working on those changes @chetak123 and everybody else for the feedback! /lgtm |
/assign tabbysable IanColdwater |
Hi Ayushman! Thank you so much for contributing this README! We really appreciate your work. :) We as chairs have been wanting to add language that accurately reflects who we are and what we do as a SIG, because SIG Security has evolved a lot since the original charter was written. We are currently workshopping that language and plan to suggest that to you as an inline change next week. Thank you so much for your patience, and looking forward to merging this! |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale @tabbysable bump on this. looks like the README still says |
so much anticipation 👀 ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the discussion in the last SIG Security meeting where everyone agreed we should ship this now and collectively iterate on it later, /approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chetak123, IanColdwater The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For the record, and the joy of doing so: |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thank you @chetak123 for working on this and for your patience while we all worked out what was best for our beloved SIG 🎉 |
Signed-off-by: Ayushman Mishra [email protected]
Issue : #14