Skip to content

Added README #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2023
Merged

Added README #24

merged 5 commits into from
Feb 28, 2023

Conversation

chetak123
Copy link
Member

Signed-off-by: Ayushman Mishra [email protected]

Issue : #14

Signed-off-by: Ayushman Mishra <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2021
@PushkarJ
Copy link
Member

/cc @savitharaghunathan

(since the relevant issue #14 is a duplicate of #20, that you created)

Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits. Otherwise lgtm.

@chetak123
Copy link
Member Author

Hey @savitharaghunathan can you please review my PR and give me some helpful suggestions if required.

README.md Outdated
- Slack: [#sig-security](https://kubernetes.slack.com/messages/sig-security)
- [Mailing list](https://groups.google.com/forum/#!forum/kubernetes-sig-security)
- [Open Community Issues/PRs](https://github.com/kubernetes/community/labels/sig%2Fsecurity)
- [Sig-Security Issues](https://github.com/kubernetes/sig-security/issues)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Sig-Security Issues](https://github.com/kubernetes/sig-security/issues)
- [SIG Security Issues](https://github.com/kubernetes/sig-security/issues)

@raesene
Copy link
Contributor

raesene commented Sep 6, 2022

Hey all , I was just thinking "it'd be nice if we had a README" then realise this was here :) what do we think needs done to get this one merged?

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried all the URLs and everything seems correct!

Just a nit to remove the template comments in the markdown that are no longer needed but do not appear anyway so...

Sorry for not reviewing sooner and thanks so much for taking the time to write the SIG readme!

README.md Outdated
Comment on lines 1 to 2
<!---
This is an autogenerated file!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!---
This is an autogenerated file!

README.md Outdated
Comment on lines 4 to 5
Please do not edit this file directly, but instead make changes to the
sigs.yaml file in the project root.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please do not edit this file directly, but instead make changes to the
sigs.yaml file in the project root.

README.md Outdated
Comment on lines 7 to 8
To understand how this file is generated, see https://git.k8s.io/community/generator/README.md
--->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To understand how this file is generated, see https://git.k8s.io/community/generator/README.md
--->

README.md Outdated
Comment on lines 66 to 68
<!-- BEGIN CUSTOM CONTENT -->

<!-- END CUSTOM CONTENT -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- BEGIN CUSTOM CONTENT -->
<!-- END CUSTOM CONTENT -->

@mtardy
Copy link
Member

mtardy commented Sep 9, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2022
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor suggestion. Otherwise, lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2022
@PushkarJ
Copy link
Member

Thanks for working on those changes @chetak123 and everybody else for the feedback!

/lgtm
/assign @tabbysable @IanColdwater

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2022
@PushkarJ
Copy link
Member

/assign tabbysable IanColdwater

@PushkarJ PushkarJ removed their assignment Sep 18, 2022
@IanColdwater
Copy link
Contributor

Hi Ayushman! Thank you so much for contributing this README! We really appreciate your work. :)

We as chairs have been wanting to add language that accurately reflects who we are and what we do as a SIG, because SIG Security has evolved a lot since the original charter was written. We are currently workshopping that language and plan to suggest that to you as an inline change next week.

Thank you so much for your patience, and looking forward to merging this!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2023
@nikhita
Copy link
Member

nikhita commented Jan 13, 2023

/remove-lifecycle stale

@tabbysable bump on this. looks like the README still says Kubernetes Template Project :)

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2023
@mtardy
Copy link
Member

mtardy commented Feb 23, 2023

so much anticipation 👀 ...

Copy link
Contributor

@IanColdwater IanColdwater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the discussion in the last SIG Security meeting where everyone agreed we should ship this now and collectively iterate on it later, /approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetak123, IanColdwater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8649083 into kubernetes:main Feb 28, 2023
@tabbysable
Copy link
Member

For the record, and the joy of doing so:
/approve
/honk

@k8s-ci-robot
Copy link
Contributor

@tabbysable:
goose image

In response to this:

For the record, and the joy of doing so:
/approve
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PushkarJ
Copy link
Member

Thank you @chetak123 for working on this and for your patience while we all worked out what was best for our beloved SIG 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants