Skip to content

add stewart-yu to OWNER files #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

stewart-yu
Copy link
Contributor

@stewart-yu stewart-yu commented Aug 20, 2018

Forgot comment to PR, I'd like add myself to OWNER file because /pointer directory own to me : https://github.com/kubernetes/utils/tree/master/pointer
Thanks

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 20, 2018
OWNERS Outdated
@@ -5,11 +5,13 @@ approvers:
- deads2k
- lavalamp
- mengqiy
- stewart-yu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This grants pretty broad control - do you want to add an OWNERS to the specific subdir?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, add to pointer directoty. thanks

@stewart-yu stewart-yu force-pushed the stewart-utils-pointers branch from 62c729f to 011bbbe Compare September 7, 2018 00:14
@thockin
Copy link
Member

thockin commented Sep 18, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stewart-yu, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit cd34563 into kubernetes:master Sep 18, 2018
@stewart-yu stewart-yu deleted the stewart-utils-pointers branch September 19, 2018 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants