-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Clarifying the purpose and intended use of a ConfigMap #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Not sure how to associate this pull request with my Red Hat credentials. [email protected] |
@@ -19,6 +19,8 @@ or used to store configuration data for system components such as controllers. | |||
to [Secrets](/docs/user-guide/secrets/), but designed to more conveniently support working with strings that do not | |||
contain sensitive information. | |||
|
|||
Note: ConfigMaps are not intended to act as a replacement for a properties file. ConfigMaps are more intended to act a reference to multipe propertie files. You can think of them as way to represent something similar to the /etc directory and all it's files on a Linux computer. This model for ConfigMaps becomes especially apparent when looking at creating Volumes from ConfigMaps. Each data item in the ConfigMap becomes a new file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
propertie
typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, "multiple" instead of "multipe". I'd reword the sentence to: " ConfigMaps are intended to act a reference to multiple property files"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also "its" instead of "it's"
@eparis Anything I should do to move this along? |
CLAs look good, thanks! |
Fix the typo and it seems you need to rebase. |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Small docs issues. Please update and I'll merge. |
Fixed the wording with an additional commit. I'll merge. |
This change is