Skip to content

Mark WarningHeader feature gate as GA #28032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2021
Merged

Mark WarningHeader feature gate as GA #28032

merged 1 commit into from
May 28, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 18, 2021 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone May 18, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented May 18, 2021 •
edited
Loading

Deploy Preview for kubernetes-io-vnext-staging processing.

Building with commit 1500f14

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60a51cb19f4d4300082e713d

@liggitt liggitt mentioned this pull request May 18, 2021
Closed
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels May 18, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 18, 2021
@PI-Victor
Copy link
Member

really appreciate it, thank you!

/assign

sftim
sftim previously requested changes May 19, 2021
View reviewed changes
@sftim sftim dismissed their stale review May 20, 2021 20:05

Fixed!

@sftim
Copy link
Contributor

sftim commented May 20, 2021

LGTM
Tech review needed, but should be trivial.

@liggitt
Copy link
Member Author

liggitt commented May 20, 2021

/hold cancel

kubernetes/kubernetes#100754 is merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2021
@kbhawkey
Copy link
Contributor

Page preview:
https://deploy-preview-28032--kubernetes-io-vnext-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2021
@kbhawkey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6fcb7b9e8c5737117fce1db725e74cb8c1bafc6b

@k8s-ci-robot k8s-ci-robot merged commit 67b9b0b into kubernetes:dev-1.22 May 28, 2021
@liggitt liggitt deleted the warning-ga branch August 19, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jimangel jimangel Awaiting requested review from jimangel

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@kbhawkey kbhawkey

@PI-Victor PI-Victor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @k8sio-netlify-preview-bot @PI-Victor @sftim @kbhawkey @k8s-ci-robot