Update to k8s 1.30 #26
Conversation
kubevirt-bot
added
release-note
|
struggling to view the changes on my browser, meanwhile, I believe you'll need to bump golang with something like |
| @@ -1,27 +1,28 @@ | |||
| module kubevirt.io/controller-lifecycle-operator-sdk/api | |||
|
|
|||
| go 1.17 | |||
| go 1.22.0 | |||
There was a problem hiding this comment.
kubevirt/kubevirt#12130 is a clearer format IMO
There was a problem hiding this comment.
Not sure it matters much given this is a library repo but can we stick with this for now until we have a consensus in kubevirt?
Signed-off-by: Michael Henriksen <[email protected]>
| @@ -544,7 +544,7 @@ func (r *Reconciler) GetAllDeployments(cr client.Object) ([]*appsv1.Deployment, | |||
| // WatchCR registers watch for the managed CR | |||
| func (r *Reconciler) WatchCR() error { | |||
| // Watch for changes to managed CR | |||
| return r.controller.Watch(source.Kind(r.getCache(), r.crManager.Create()), &handler.EnqueueRequestForObject{}) | |||
| return r.controller.Watch(source.Kind(r.getCache(), r.crManager.Create(), &handler.EnqueueRequestForObject{})) | |||
There was a problem hiding this comment.
was going to tag this and ask how we feel about not doing TypedEnqueueRequestForObject here
There was a problem hiding this comment.
It is perfectly fine because the type returned by r.crManager.Create() is client.Object
There was a problem hiding this comment.
yeah but couldn't we get rid of this in favor of TypedEnqueueRequestForObject to receive the benefits of kubernetes-sigs/controller-runtime#2783
There was a problem hiding this comment.
I don't see much of an advantage to us. What specifically are you keen on?
If you feel strongly, it would require an API change (add template param to cr manager) and best handled in subsequent PR
There was a problem hiding this comment.
I guess the main thing would be something like avoiding a type assertion inside the predicate which we're anyway not using here, so I am fine
| @@ -26,7 +26,8 @@ set -ex | |||
|
|
|||
| # Extend path to use also local installation of the golang | |||
| export PATH=$PATH:/usr/local/go/bin | |||
| export KUBEVIRT_PROVIDER=$TARGET | |||
| #project-infra is passing in 1.24 but let's ignore that | |||
There was a problem hiding this comment.
Signed-off-by: Michael Henriksen <[email protected]>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: