Skip to content

Fix the .editorconfig to use TAB as indent style #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2016
Merged

Fix the .editorconfig to use TAB as indent style #22

merged 3 commits into from
Jul 18, 2016

Conversation

rafaelhz
Copy link
Contributor

The eslint config for indent style is defined as Tab, but in the .editorconfig file it was space

The eslint config for indent style is defined as Tab, but in the
.editorconfig file it was space
@coveralls
Copy link

coveralls commented Jul 15, 2016

Coverage Status

Coverage remained the same at 94.388% when pulling 9bef987 on rafaelhz:master into 4271999 on KunalKapadia:master.

@kunalkapadia
Copy link
Owner

@rafaelhz Let's use the mostly widely approach of using 2 spaces. So instead of updating .editorconfig, can you please update.eslintrc with spaces ?

@coveralls
Copy link

coveralls commented Jul 16, 2016

Coverage Status

Coverage remained the same at 94.388% when pulling e762714 on rafaelhz:master into 4271999 on KunalKapadia:master.

@rafaelhz
Copy link
Contributor Author

There is no right way to indent code, but the most part of Js libs prefer 2 spaces :)

@kunalkapadia kunalkapadia merged commit 4ef4dac into kunalkapadia:master Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants