AnnoFab WebAPIのエンドポイントを設定可能にする #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohama
reviewed
Jan 22, 2020
annofabapi/api.py
Outdated
| self.session = requests.Session() | ||
|
|
||
| #: アクセスするURL | ||
| URL_PREFIX = "https://annofab.com/api/v1" | ||
| URL_PREFIX = f"{DEFAULT_ENDPOINT_URL}/v1" |
There was a problem hiding this comment.
ここにあるクラス変数の URL_PREFIX は不要じゃないでしょうか
There was a problem hiding this comment.
_request_wrapperメソッドと、loginメソッドの2か所で使っているので、必要だと思いました。
annofab-api-python-client/annofabapi/api.py
Line 171 in 6efa5b6
annofab-api-python-client/annofabapi/api.py
Line 233 in 6efa5b6
There was a problem hiding this comment.
すみません、クラス変数とインスタンス変数を勘違いしていました…
- クラス変数の
url_prefixは不要です。 - インスタンス変数の
self.url_prefixは、他のメソッドで使用しているので必要です。
cohama
reviewed
Jan 22, 2020
annofabapi/api.py
Outdated
|
|
||
| if not login_user_id or not login_password: | ||
| raise ValueError("login_user_id or login_password is empty.") | ||
|
|
||
| self.login_user_id = login_user_id | ||
| self.login_password = login_password | ||
|
|
||
| self.endpoint_url = endpoint_url | ||
| self.URL_PREFIX = f"{endpoint_url}/v1" |
There was a problem hiding this comment.
もともと定数として扱っていたので、大文字にしていました。
今回の対応で定数ではなくなったので、小文字に変更します。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #110