Skip to content

poetry update: ruff, mypyのバージョンアップ #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Conversation

yuji38kwmt
Copy link
Collaborator

No description provided.

@yuji38kwmt yuji38kwmt requested a review from Copilot March 21, 2025 01:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency versions in the Poetry configuration and makes a few related code cleanup changes. Key changes include:

  • Updating ruff to version ^0.11 and mypy configuration in pyproject.toml.
  • Refining date conversion in _get_from_and_to_date_for_statistics_webapi and fixing typos in function names (e.g. correcting "senritive" to "sensitive") in annofabapi/api.py.
  • Adjusting type annotations and return types in parser functions and adding overloads for request body masking functions.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
annofabapi/wrapper.py Updated docstring details and date conversion using fromisoformat.
annofabapi/api.py Corrected typos in function names, and added type overloads.
annofabapi/resource.py Removed extraneous lint comment from import.
annofabapi/parser.py Updated import ordering and adjusted return type annotation.
pyproject.toml Upgraded ruff version and updated mypy settings.
Comments suppressed due to low confidence (1)

annofabapi/parser.py:484

  • [nitpick] Ensure that the updated return type 'FullAnnotationParser' is intentional, as the previous version returned 'SimpleAnnotationParser'. Verify that downstream code correctly handles the change.
def lazy_parse_full_annotation_dir(annotation_dir_path: Path) -> Iterator[FullAnnotationParser]:

@yuji38kwmt yuji38kwmt merged commit bea73d9 into main Mar 21, 2025
8 checks passed
@yuji38kwmt yuji38kwmt deleted the update-poetry branch March 21, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant