Skip to content

Applied recommendation from Xcode 10 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

radianttap
Copy link

This cleans up the warning in Xcode 10.

@quver
Copy link

quver commented Sep 18, 2018

@radianttap I don't know why, but again you have the conflict

@radianttap
Copy link
Author

radianttap commented Sep 18, 2018

It's the same issue :(

Is anyone actually using the code directly from master..? It seems everyone just uses the public pod.

@jorunfa
Copy link

jorunfa commented Sep 18, 2018

Is anyone actually using the code directly from master..? It seems everyone just uses the public pod.

Using latest public pod, currently.

Doesn't look like .podspec file exists anymore, only Package.swift - is the intention to move the project away from Cocoapods and instead use Swift Package Manager?

@mihailsalari
Copy link

Hi, this PR fix the "Command CompileSwiftSources failed with a nonzero exit code" error?

Regards

@radianttap
Copy link
Author

@mihailsalari No. I did not see that error.
It's a minor thing, fixing the deprecated API call.

@kylef
Copy link
Owner

kylef commented Sep 23, 2019

Thanks @radianttap, I've merged in #112 which contains this change.

@kylef kylef closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants