Resolve fiber === null in certain app structures / conditions #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolves an issue in the event processing pipeline where fibers return null and result in a critical error (loading fails, event queue continues to grow) - Applies a band-aid solution to a "knock-on" effect of the fix that results in missing / invalid fibers in active trees / fiber maps, causing the UI render to fail in REMPL
theprojectsomething
force-pushed
the
abcdigital/resolve-missing-fibers
branch
from
cb23672 to
13c7b74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #32, when rendering our (large) react app, RRT was reporting critical errors and either hanging before or during render, resulting in - at best - a selection of orphaned nodes in the Rempl viewer.
Unsure of the specifics leading to the error in our use case. Am hazarding a guess that it may be due to app size / efficiencies relating to the message bus (on initial render there are between 4-8k items in the load queue, which increase as the page is used) or the possibility of multiple react roots due to e.g. third party scripts, dev environment tools, etc. But it could be something else entirely.
This fix is knowingly ignorant but, as far as we can tell, resolves the issues in rendering our app. There may be side effects we are unaware of. Specifically it includes two minor changes that:
We're currently (successfully) hotlinking to a build from this fork, but are hoping to be able to help resolve the root cause upstream and revert to the main cdn package.
Note: this PR is intended to evolve based on feedback 😅
Should also note, loving the project. Very welcome addition to the react toolset. Keen to contribute however we can.