Eloquent ORM goes OOM on delete() for a model without primary key

[DSpeichert]

For a model with:

protected $primaryKey = null;

when $instance->delete() is called, it fails with out of memory fatal error.

[anlutro]

That's odd, but it's worth noting that delete() is not designed to work at all without a primary key.

[Anahkiasen]

What column is it supposed to delete with ?

[DSpeichert]

If there is no primary key, it could delete specifying all columns. In any case, it should not fail with OOM but with a more meaningful error.
Still, using all columns to delete instance of a model without a primary key is the most anticipated action unless specifying an array for $primaryKey is possible.

[anlutro]

If you were to implement that, (new MyModel())->delete() would delete the entire table, and you would often risk unintentional deletes. I think that would be a pretty bad idea.

[DSpeichert]

That is true but it's not like you can accidentally put this into the code. Cases of models without primary key are rare anyway.

How about implementing $primaryKey being an array to support MySQL's combined primary keys?

[manan-jadhav]

@DSpeichert , you can use an array as a PK.

[JosephSilber]

@anlutro Checking $this->exists first would mitigate the (new MyModel())->delete() problem.

(not that I think this should be implemented. Just saying).

[taylorotwell]

Fixed.

[YOzaz]

Still doesn't work.

class Article extends \Eloquent
{
    use \Illuminate\Database\Eloquent\SoftDeletingTrait;
    public $incrementing = false;
    protected $primaryKey = [
        'article_id',
        'publisher_id'
    ];

$item = Article::where('article_id', 1)->where('publisher_id', 1)->first();
// works fine
$item->delete();
// throws Exception

Result:

ErrorException
array_key_exists(): The first argument should be either a string or an integer
\vendor\laravel\framework\src\Illuminate\Database\Eloquent\Model.php:2297

public function getAttribute($key)
{
    $inAttributes = array_key_exists($key, $this->attributes);

[lazlo-bonin]

@YOzaz is right, I get the same exception.

I think Eloquent expects a string primary key to delete there, and can't handle cases where the primary key is a composite defined through an array (where it should add multiple constraints in the where).