Fluent orderBy doesn't convert camelCase to snake_case

[assertchris]

The field is last_name and ->orderBy("lastName", "asc") errors....

[franzliedke]

Sad to say this, but this whole camel-casing thing is really turning into a mess.

[conradkleinespel]

👍 @franzliedke. I've set up email notifications for Laravel so I can check out PRs and issues. Half of them seem to be somehow related to snake / camel casing. It's getting pretty annoying.

I don't get how converting to snake case makes things any better (not that it bothers me, I use snake case anyway...). Could we please have your input on this @taylorotwell ?

[Anahkiasen]

Yup, I'd rather strip out the feature and let users deal with it themselves, this is getting out of hand in my opinion.

[alexwhitman]

PSR-0 only defines that the 'PHP' bits are camel case. In this case it's a string which would be correct if using camel case columns in the DB.

[assertchris]

@alexwhitman It's not about what needs to be camelCase or snake_case, but rather the consistency with which the snake_case to camelCase transformations are applied in cohesive behaviors. If I can treat last_name as if it were lastName in object accessors and model assignment then I should be able to do it in fluent methods also...

[alexwhitman]

That's certainly true but getters/setters are a different issue from your original example of ->orderBy("lastName", "asc") which shouldn't be converted.

[assertchris]

@alexwhitman you can currently use ->where("createdAt", "=", "2013-02-20 13:12:18") which will filter on the created_at field...

[alexwhitman]

In that case disregard what I've just said.

I've only been developing new apps with Laravel but this would make it hard to work with some legacy apps that have strange column naming schemes (or rather lack of naming schemes) and so probably should be removed.

[taylorotwell]

Eloquent has always required snake_case column names, and Laravel 4 is no different. PSR doesn't even dictate property names, and actually states that they can be either snake_case or camelCase. Just use snake_case with Eloquent like you always have. It's really not that complicated I don't think.

[assertchris]

I don't mind juggling that sort of thing. The the point of this issue is that ->where("lastName", "=", "pitt") and ->orderBy("last_name", "asc") are inconsistent.

[taylorotwell]

Just use the casing of your database fields. There is no magic going on.