[12.x] Fix: Support taggeable store flushed cache events #55157
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Barryvdh\Debugbar\DataCollector\CacheCollector::onCacheEvent(): Argument #1 ($event) must be of type Illuminate\Cache\Events\CacheEvent, Illuminate\Cache\Events\CacheFlushed given, called in /var/www/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php on line 460
I think it would be more consistent if it extended from
Illuminate\Cache\Events\CacheEvent
, look laravel debugbar DataCollector/CacheCollector.php#L33also there is a TaggeableStore (
tags
),but it does not allow adding tags as an argument
framework/src/Illuminate/Cache/Events/CacheEvent.php
Line 35 in dd16215
framework/src/Illuminate/Cache/TaggedCache.php
Lines 104 to 113 in dd16215
it seems I'll have to highlight the signature.
* @param \Illuminate\Cache\Events\CacheEvent $event
framework/src/Illuminate/Cache/TaggedCache.php
Line 107 in 46ac782