-
Notifications
You must be signed in to change notification settings - Fork 846
Install fails with fresh, bone-stock Laravel instance. #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I confirm the issue with
It happens on fresh install and the workaround mentioned by @unrivaledcreations works |
I had the same issue.
|
after you put It works for me. |
same issue with inertia Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions. |
Oh Thank you so much, I´ll take a look right now!
…On Sat, Jul 24, 2021 at 10:50 PM Muammar Khadafi ***@***.***> wrote:
after you put
"league/commonmark": "^1.3"
on composer.json
You must delete composer.lock before you run composer require
laravel/jetstream.
It works for me.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#838 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU6Y6W4OQFLKJAEO23GTSVTTZOCX3ANCNFSM5A53B5LQ>
.
|
Great !
It worked for me too!
I found also, another way to resolve it:
After place"league/commonmark": "^1.3", I installed, in the root of the
project:
composer require league/commonmark:^1.3
and it worked for me too!
…On Sat, Jul 24, 2021 at 10:50 PM Muammar Khadafi ***@***.***> wrote:
after you put
"league/commonmark": "^1.3"
on composer.json
You must delete composer.lock before you run composer require
laravel/jetstream.
It works for me.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#838 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU6Y6W4OQFLKJAEO23GTSVTTZOCX3ANCNFSM5A53B5LQ>
.
|
Tagged v2.3.12 with a fix. Thanks everyone for reporting. |
Guys, do you still have this problem as me? I'm using CommonMark ver 2.0 and this package does not contain this class. So, after updating packages on my app It broke and I need to manually put ^1.3 on my composer.json. |
@RomanSarvarov commonmark 2.0 deprecates and changes quite a few things. This breaks the implementation that jetstream is using for the Terms/Privacy Policy feature. You can work around by updating the Controllers in the vendor folder with the new way to use the GithubFlavoredMarkdownConverter. TermsOfServiceController: <?php
namespace Laravel\Jetstream\Http\Controllers\Livewire;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Laravel\Jetstream\Jetstream;
use League\CommonMark\GithubFlavoredMarkdownConverter;
class TermsOfServiceController extends Controller
{
/**
* Show the terms of service for the application.
*
* @param \Illuminate\Http\Request $request
* @return \Illuminate\View\View
*/
public function show(Request $request)
{
$termsFile = Jetstream::localizedMarkdownPath('terms.md');
return view('terms', [
'terms' => (new GithubFlavoredMarkdownConverter())->convertToHtml(file_get_contents($termsFile)),
]);
}
} PrivacyPolicyController: <?php
namespace Laravel\Jetstream\Http\Controllers\Livewire;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Laravel\Jetstream\Jetstream;
use League\CommonMark\GithubFlavoredMarkdownConverter;
class PrivacyPolicyController extends Controller
{
/**
* Show the privacy policy for the application.
*
* @param \Illuminate\Http\Request $request
* @return \Illuminate\View\View
*/
public function show(Request $request)
{
$policyFile = Jetstream::localizedMarkdownPath('policy.md');
return view('policy', [
'policy' => (new GithubFlavoredMarkdownConverter())->convertToHtml(file_get_contents($policyFile)),
]);
}
} |
Tagged v2.3.14 with a fix. |
^1.3|^2.0
(viacomposer.json
)Description:
Getting a Composer error on install, using the command
composer require laravel/jetstream
:The bone-stock Laravel installation uses Jetstream v2 because
vendor/laravel/framework/src/Illuminate/Mail/composer.json
contains"league/commonmark": "^1.3|^2.0"
. However, Jetstream'scomposer.json
requires"league/commonmark"
"^1.3"
. This breaks the installation process because the core Laravel framework already installed v2.x when Jetstream seems to insist on v1.3 (of theleague/commonmark
dependency).Steps To Reproduce:
The single command,
laravel new --jet --stack=inertia test
, also fails for the same reason.Workaround:
Manually adding
"league/commonmark": "^1.3",
to the rootcomposer.json
project file beforecomposer require laravel/jetstream
seems to work around the problem.The text was updated successfully, but these errors were encountered: