Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix banner not showing again if dismissed by the user #1045

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fix banner not showing again if dismissed by the user #1045

merged 1 commit into from
Apr 25, 2022

Conversation

LucaRed
Copy link
Contributor

@LucaRed LucaRed commented Apr 24, 2022

This fixes a long-standing bug, see #696 (and rejected PRs #826 and #1026).

How to reproduce:

  1. Flash a banner.
  2. The user acknowledges the banner and clicks on the x button.
  3. Flash another banner.
  4. No banners will be shown again, unless the user manually reloads the page or does a non-Inertia navigation.

As suggested by @claudiodekker, this PR adds a simple watch that displays the banner again when a new message is flashed by the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants